Skip to content

Conversation

@Charles-Gagnon
Copy link
Contributor

@Charles-Gagnon Charles-Gagnon commented Jun 5, 2025

Description

We had pinned Azure.Core and Azure.Identity to resolve a CVE in the Azure.Identity package <1.11.4, but after looking into it that doesn't seem to be necessary since the version of SqlClient we use already requires that to be >=1.11.4

https://www.nuget.org/packages/Microsoft.Data.SqlClient/5.2.2#dependencies-body-tab

So having these direct dependencies is just adding unnecessary requirements on our package since we don't actually reference these directly.

Code Changes

  • Unit tests are added, if possible
  • Integration tests are added if the change is modifying existing behavior of one or more of the bindings
  • New or changed code follows the C# style guidelines defined in .editorconfig
  • All changes MUST be backwards compatible and changes to the shared az_func.GlobalState table must be compatible with all prior versions of the extension
  • Use the ILogger instance to log relevant information, especially information useful for debugging or troubleshooting
  • Use async and await for all long-running operations
  • Ensure proper usage and propagation of CancellationToken
  • T-SQL is safe from SQL Injection attacks through the use of SqlParameters and proper escaping/sanitization of input

Dependencies

Documentation

  • Add samples if the change is modifying or adding functionality
  • Update relevant documentation in the docs

@Charles-Gagnon Charles-Gagnon marked this pull request as ready for review June 10, 2025 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants