Skip to content

Fix typing inspect issue #766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 14, 2020
Merged

Fix typing inspect issue #766

merged 1 commit into from
Oct 14, 2020

Conversation

Hazhzeng
Copy link
Contributor

@Hazhzeng Hazhzeng commented Oct 14, 2020 •
edited
Loading

Description

Typing inspect issue: now the Python 3.8 _GenericAlias is diverged into two different path in Python 3.9, _GenericAlias and _SpecialGenericAlias. See https://bugs.python.org/issue40397

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and CI is passing.

Quality of Code and Contribution Guidelines

@Hazhzeng Hazhzeng merged commit b84b825 into dev Oct 14, 2020
@Hazhzeng Hazhzeng deleted the hazeng/fix-python39 branch October 14, 2020 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vrdmr vrdmr vrdmr approved these changes

@anirudhgarg anirudhgarg Awaiting requested review from anirudhgarg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hazhzeng @vrdmr