feat: improve JSON error logging for Durable #298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andystaples
requested review from
vrdmr,
gavin-aguiar and
hallvictoria
as code owners
andystaples
changed the title
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| raise ValueError( | ||
| 'activity trigger input must be a string or a ' | ||
| f'valid json serializable ({data.value})') | ||
| f'valid json serializable ({data.value})') from e |
There was a problem hiding this comment.
nit: could you add a unit test for this in tests/test_durable_functions.py?
There was a problem hiding this comment.
Done - let me know if you need to see more cases - I figured as long as the error was there in one case, that was sufficient
There was a problem hiding this comment.
LGTM - this change can be part of v1.25.0. We're looking to release 1.25.0b1 by end of October - lmk if there's any concerns over timelines!
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if to_json fails, we discard the original failure and raise our own ValueError - this PR makes the new exception inherit from the original exception, making debugging serialization issues easier.