Upgrade version of Microsoft.Azure.WebJobs.Extensions.Http to remove vulnerability #493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vulneratbility. There is a vulnerability in Microsoft.AspNetcore.Http in 2.1.0 that we need to upgrade References: - GHSA-hxrm-9w7p-39cc - dotnet/aspnetcore#24264
Contributor
Author
|
Hi @justinyoo - Please take a peek at this PR, there's a high vulnerability that should be resolved for consumers of this library. |
|
@justinyoo I will second the request on this item. |
justinyoo
suggested changes
Oct 17, 2022
Contributor
justinyoo
left a comment
justinyoo
left a comment
There was a problem hiding this comment.
Thanks @jackbatzner for this PR. I've left some comments for you to take a look.
...Azure.WebJobs.Extensions.OpenApi.Core/Microsoft.Azure.WebJobs.Extensions.OpenApi.Core.csproj
Outdated
Show resolved
Hide resolved
...nApi.FunctionApp.InProc/Microsoft.Azure.WebJobs.Extensions.OpenApi.FunctionApp.InProc.csproj
Outdated
Show resolved
Hide resolved
...nApi.FunctionApp.InProc/Microsoft.Azure.WebJobs.Extensions.OpenApi.FunctionApp.InProc.csproj
Outdated
Show resolved
Hide resolved
...WebJobs.Extensions.OpenApi.TestApp/Microsoft.Azure.WebJobs.Extensions.OpenApi.TestApp.csproj
Outdated
Show resolved
Hide resolved
...WebJobs.Extensions.OpenApi.TestApp/Microsoft.Azure.WebJobs.Extensions.OpenApi.TestApp.csproj
Outdated
Show resolved
Hide resolved
justinyoo
suggested changes
Oct 17, 2022
Contributor
justinyoo
left a comment
justinyoo
left a comment
There was a problem hiding this comment.
Let's focus on the NuGet package update in this PR. Please remove the two other C# file updates from this PR and create a new one.
src/Microsoft.Azure.WebJobs.Extensions.OpenApi.Core/Extensions/TypeExtensions.cs
Outdated
Show resolved
Hide resolved
...zure.WebJobs.Extensions.OpenApi.Core.Tests/Visitors/ListObjectInheritanceTypeVisitorTests.cs
Outdated
Show resolved
Hide resolved
justinyoo
suggested changes
Oct 17, 2022
Contributor
justinyoo
left a comment
justinyoo
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the PR
justinyoo
approved these changes
Oct 17, 2022
|
Thanks to @jackbatzner for the fix, and @justinyoo for being responsive! |
Derich367
pushed a commit
to Derich367/azure-functions-openapi-extension
that referenced
this pull request
Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a vulnerability in Microsoft.AspNetcore.Http in 2.1.0 that we need to upgrade
References: