Skip to content

Minor fixes to be consistent with library repo hooks PR #725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Minor fixes to be consistent with library repo hooks PR #725

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Disposable.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

/**
* Based off of VS Code
* https://github.com/microsoft/vscode/blob/a64e8e5673a44e5b9c2d493666bde684bd5a135c/src/vs/workbench/api/common/extHostTypes.ts#L32
* https://github.com/microsoft/vscode/blob/7bed4ce3e9f5059b5fc638c348f064edabcce5d2/src/vs/workbench/api/common/extHostTypes.ts#L65
*/
export class Disposable {
static from(...inDisposables: { dispose(): any }[]): Disposable {
Expand All @@ -27,7 +27,7 @@ export class Disposable {
}

dispose(): any {
if (this.#callOnDispose instanceof Function) {
if (typeof this.#callOnDispose === 'function') {
this.#callOnDispose();
this.#callOnDispose = undefined;
}
Expand Down
2 changes: 1 addition & 1 deletion types-core/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,7 @@ declare module '@azure/functions-core' {
inputs: unknown[];
}

type FunctionCallback = (context: unknown, ...inputs: unknown[]) => unknown;
type FunctionCallback = (...args: unknown[]) => unknown;

// #region rpc types
interface RpcFunctionMetadata {
Expand Down