Skip to content

Simplifies the messy logics on paramter resolving #730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: feature/sdk-binding
Choose a base branch
from
Open

Simplifies the messy logics on paramter resolving #730

wants to merge 1 commit into from

Conversation

kaibocai
Copy link
Member

@kaibocai kaibocai commented Sep 26, 2023 •
edited
Loading

clean up more

Issue describing the changes in this PR

This PR simplifies the messy logic of parameter-resolving.

  1. Removed the unnecessary InstanceSupplier to make this logic cleaner. The existing test cases still cover all the updated logic.
  2. Removed the unnecessary nested map using UUID.

This PR can be taken as preparation work for SDK binding.

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Additional PR information

@kaibocai kaibocai changed the base branch from dev to feature/sdk-binding September 27, 2023 14:39
@kaibocai
clean up
478821e 
clean up more

move resolver to dedicate package

rename resolver to converter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anirudhgarg anirudhgarg Awaiting requested review from anirudhgarg anirudhgarg is a code owner

@TsuyoshiUshio TsuyoshiUshio Awaiting requested review from TsuyoshiUshio TsuyoshiUshio is a code owner

@amamounelsayed amamounelsayed Awaiting requested review from amamounelsayed amamounelsayed is a code owner

@shreyas-gopalakrishna shreyas-gopalakrishna Awaiting requested review from shreyas-gopalakrishna shreyas-gopalakrishna is a code owner

@kamperiadis kamperiadis Awaiting requested review from kamperiadis kamperiadis is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@kaibocai