Use a single classloader for java 11 #460
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreyas-gopalakrishna
requested review from
TsuyoshiUshio,
amamounelsayed and
anirudhgarg
as code owners
src/main/java/com/microsoft/azure/functions/worker/reflect/EnhancedClassLoaderProvider.java
Show resolved
Hide resolved
trask
reviewed
Sep 24, 2021
|
|
||
| urls.add(url); | ||
| } | ||
| private final Set<URL> urls; |
There was a problem hiding this comment.
Suggested change
| private final Set<URL> urls; | |
| private final Set<URL> urls; | |
| private final Object lock = new Object(); |
| */ | ||
| private URLClassLoader getURLClassLoaderInstance(URL[] urlsForClassLoader) { | ||
| if (classLoaderInstance == null) { | ||
| synchronized (URLClassLoader.class) { |
There was a problem hiding this comment.
Suggested change
| synchronized (URLClassLoader.class) { | |
| synchronized (lock) { |
trask
reviewed
Sep 24, 2021
| * @param urlsForClassLoader Array of URLs to construct a new URLClassLoader | ||
| * @return single instance of URLClassLoader | ||
| */ | ||
| private URLClassLoader getURLClassLoaderInstance(URL[] urlsForClassLoader) { |
There was a problem hiding this comment.
no need to pass args here, calculate below instead
trask
reviewed
Sep 27, 2021
| public ClassLoader createClassLoader() { | ||
| URL[] urlsForClassLoader = new URL[urls.size()]; | ||
| urls.toArray(urlsForClassLoader); | ||
| return createURLClassLoaderInstance(); |
There was a problem hiding this comment.
just a style thought, can inline the createURLClassLoaderInstance method here
trask
reviewed
Sep 27, 2021
Comment on lines
35
to
36
| classLoaderInstance = new URLClassLoader(urlsForClassLoader); | ||
| loadDrivers(classLoaderInstance); |
There was a problem hiding this comment.
good to assign the field at the very end, so that another thread can't come in and return classLoaderInstance prior to it being fully initialized
Suggested change
| classLoaderInstance = new URLClassLoader(urlsForClassLoader); | |
| loadDrivers(classLoaderInstance); | |
| URLClassLoader loader = new URLClassLoader(urlsForClassLoader); | |
| loadDrivers(loader); | |
| classLoaderInstance = loader; |
trask
previously approved these changes
Sep 27, 2021
amamounelsayed
previously approved these changes
Sep 28, 2021
shreyas-gopalakrishna
dismissed stale reviews from amamounelsayed and trask
via
4f9ba39
shreyas-gopalakrishna
force-pushed
the
v4_classloader
branch
from
61a1d17 to
4f9ba39
Compare
trask
approved these changes
Sep 28, 2021
amamounelsayed
approved these changes
Sep 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Code changes
#412