-
Notifications
You must be signed in to change notification settings - Fork 66
Update for Distributed Tracing #411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @amamounelsayed CI looks fails by CosmosDB that is not related this change. I'll re-run it. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Looks refused from the server. Usually Network Issue. Other things I found is the worker start using .Net 5 |
|
I run the pipeline one more time, If it won't fix, I'll make the client to static. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
I found the root cause of the CI fails. It looks reach the timeout when it reach the CosmosDB for reading a document. I can't see the CosmosDB resource from my subscription. Other socket exception is subsequent result of the timeout. So that I increase the timeout for solving it. |
|
@TsuyoshiUshio tested the Java_opts and new env AZURE_FUNCTIONS_MESH_JAVA_OPTS and both work together and do not override each others. |
update table style Add link to the contributor markdown Add more details on how to debug the new java worker code contributor-guide added tasks.json example Remove Github Action section from Contribution README Address code review comment Update for Distributed Tracing (Azure#411) It includes fix of the CI. I've done two things. 1. Fix timeout issue on CosmosDB. 2. Make HttpClient as static. This part is not the root cause of the CI fail, however, I keep it as better practice than instantiate eachtime. Release 1.8.1 with internal JAVA_OPTS argument (Azure#413)
This PR is for updating
worker.configfor enabling distributed tracing.I introduced
AZURE_FUNCTIONS_MESH_JAVA_OPTSto the argument.At first, I used
JAVA_OPTShowever, some customers seem to use it.I introduce a new variables the is used only for mesh image configuration.
Any naming suggesting is welcome.