Skip to content

Conversation

@TsuyoshiUshio
Copy link
Contributor

@TsuyoshiUshio TsuyoshiUshio commented Nov 23, 2020

This PR is for updating worker.config for enabling distributed tracing.

I introduced AZURE_FUNCTIONS_MESH_JAVA_OPTS to the argument.

At first, I used JAVA_OPTS however, some customers seem to use it.
I introduce a new variables the is used only for mesh image configuration.

Any naming suggesting is welcome.

@TsuyoshiUshio
Copy link
Contributor Author

Hi @amamounelsayed
I tested both on Windows and Mesh image. I put a log (Linux) and Debug(Windows)
on this part and find it works. https://github.com/Azure/azure-functions-host/blob/0f18eade4b28b8cdde9e6a63dd0b7d4d0a051329/src/WebJobs.Script/Workers/ProcessManagement/DefaultWorkerProcessFactory.cs#L60

CI looks fails by CosmosDB that is not related this change. I'll re-run it.

@TsuyoshiUshio
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@TsuyoshiUshio
Copy link
Contributor Author

TsuyoshiUshio commented Dec 9, 2020

Looks refused from the server. Usually Network Issue. Other things I found is the worker start using .Net 5

System.Net.Http.HttpRequestException : No connection could be made because the target machine actively refused it
---- System.Net.Sockets.SocketException : No connection could be made because the target machine actively refused it

@TsuyoshiUshio
Copy link
Contributor Author

I run the pipeline one more time, If it won't fix, I'll make the client to static.

@TsuyoshiUshio
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@TsuyoshiUshio
Copy link
Contributor Author

I found the root cause of the CI fails. It looks reach the timeout when it reach the CosmosDB for reading a document. I can't see the CosmosDB resource from my subscription. Other socket exception is subsequent result of the timeout. So that I increase the timeout for solving it.
https://azfunc.visualstudio.com/Azure%20Functions/_build/results?buildId=9802&view=ms.vss-test-web.build-test-results-tab&runId=1062300&resultId=100007&paneView=debug Could you have a look and approve it? I also change the http client to static. It is better solution, so that I keep it.

@amamounelsayed
Copy link
Collaborator

@TsuyoshiUshio tested the Java_opts and new env AZURE_FUNCTIONS_MESH_JAVA_OPTS and both work together and do not override each others.

@TsuyoshiUshio TsuyoshiUshio merged commit 0025753 into dev Dec 9, 2020
helayoty added a commit to helayoty/azure-functions-java-worker that referenced this pull request Jan 21, 2021
update table style

Add link to the contributor markdown

Add more details on how to debug the new java worker code

contributor-guide added tasks.json example

Remove Github Action section from Contribution README

Address code review comment

Update for Distributed Tracing (Azure#411)

It includes fix of the CI. I've done two things. 1. Fix timeout issue on CosmosDB. 2. Make HttpClient as static. This part is not the root cause of the CI fail, however, I keep it as better practice than instantiate eachtime.

Release 1.8.1 with internal JAVA_OPTS argument (Azure#413)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants