Skip to content

Conversation

@kaibocai
Copy link
Member

include spi artifacts in this repo.

@kaibocai
Copy link
Member Author

kaibocai commented Oct 12, 2022

CI failed because middleware classes are moved to spi library, we are using latest dev branch from worker for CI testing, so we need to update worker pom file to have it also depended on spi library.

The steps will be

  1. have this pr merge -- unfortunately CI cannot pass in this step. But can test with another branch from worker.
  2. update core lib version to 1.2.0 and release it to maven
  3. release spi lib version 1.0.0 to maven
  4. create pr on worker side to update pom file have worker depended on spi lib version 1.0.0 also update core lib version to 1.2.0

@kaibocai
Copy link
Member Author

kaibocai commented Oct 12, 2022

Point to test branch from worker in CI yml file and the CI pass.

@kaibocai kaibocai marked this pull request as ready for review October 12, 2022 21:59
@kaibocai kaibocai merged commit 90c7136 into dev Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants