Handle new command line arguments with "functions-" prefix #1897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kshyju
requested review from
aishwaryabh,
brettsam,
fabiocav,
jviau,
liliankasem,
satvu,
soninaren and
surgupta-msft
Member
Author
|
Relevant host change (still in draft because waiting for some lang workers to fix their packages to handle this): https://github.com/Azure/azure-functions-host/pull/9514/files |
jviau
reviewed
Sep 11, 2023
Contributor
There was a problem hiding this comment.
While we are enhancing this, couple comments:
- Technically command-line semantics is to start with
--, then kebab-case the argument. So it would be--functions-request-idand not--functions-requestid. - Should we map these into a specific configuration section so they don't get accidentally overriden by something unrelated? Maybe everything under
Functions:Workersection? (Functions:Worker:HostUri,Functions:Worker:RequestId,Functions:Worker:WorkerId)
jviau
reviewed
Sep 11, 2023
Member
Author
|
@jviau Pushed an update to switch to kebab case. |
…ure/azure-functions-dotnet-worker into shkr/gh-1547_new_cmdline_args
- Removed Host and Port property and using the new Uri property on GrpcWorkerStartupOptions type.
Closed
2 tasks
jviau
reviewed
Sep 13, 2023
extensions/Worker.Extensions.Rpc/src/ConfigurationExtensions.cs
Outdated
Show resolved
Hide resolved
fabiocav
reviewed
Sep 13, 2023
extensions/Worker.Extensions.Rpc/src/ConfigurationExtensions.cs
Outdated
Show resolved
Hide resolved
extensions/Worker.Extensions.Rpc/src/ConfigurationExtensions.cs
Outdated
Show resolved
Hide resolved
- Using switchMap for commandline configuraton provider. - Mapped the command line args to "Functions:Worker" section in configuration. - Added project reference (Worker.Extensions.Rpc) to Worker.Grpc to reuse the extension method.
kshyju
commented
Sep 14, 2023
Member
Author
kshyju
commented
Sep 14, 2023
jviau
reviewed
Sep 14, 2023
Contributor
jviau
left a comment
jviau
left a comment
There was a problem hiding this comment.
Looks great! Only concern is the reference to Extensions.Rpc. I suggest we just duplicate code for now. We can follow up later and see if there is an opportunity to make Extensions.Rpc appropriate for DotNetWorker.Grpc to leverage.
extensions/Worker.Extensions.Rpc/src/ConfigurationExtensions.cs
Outdated
Show resolved
Hide resolved
jviau
reviewed
Sep 14, 2023
…"GetFunctionsHostGrpcUri" in DotnetWorker.Grpc
jviau
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1900
Resolves #1547
This PR adds the relevant changes to read the new command line arguments we plan to send from the host. See the host issue Azure/azure-functions-host#9504 for understanding the need for this change.
Example of command line argument string host will send to worker process.
Pull request checklist
release_notes.mdAdditional information
Additional PR information