Skip to content

Conversation

@jupjohn
Copy link
Contributor

@jupjohn jupjohn commented Jan 24, 2025

This PR aims to take the existing 0.34.1 codebase and republish it under AwesomeAssertions. I've tested this with the base package and it works as expected.

A few minor things to note:

  1. I've pinned the SDK version of the repository to .NET 8, but not down to the patch level. That can be done separately
  2. I've also bumped the installed .NET SDK version of the release pipeline to match
    • I'm not sure how this ran upstream as these projects target .NET 8, but only 6 was installed. Odd...
  3. As @ScarletKuro has already seen, I've published this version on NuGet. It was built from this repository so the org repo won't have this build in its actions run history. If we want to republish from the org, I'm fine with that (and kinda would prefer that)

@ScarletKuro can you add the NUGET_API_KEY secret to this repo (org) please?

@ScarletKuro
Copy link
Contributor

@ScarletKuro can you add the NUGET_API_KEY secret to this repo (org) please?

We already have NUGETAPIKEY on org level, because thats what the FA and FA.Json uses, weird they use "NUGET_API_KEY" for the analyzer, i guess we can change that from NUGET_API_KEY to NUGETAPIKEY for consistency.

dotnet nuget push $nupkg --skip-duplicate --api-key ${{ secrets.NUGET_API_KEY }} --source https://api.nuget.org/v3/index.json;

Can you do it in this PR?

@jupjohn
Copy link
Contributor Author

jupjohn commented Jan 24, 2025

Key reference updated in 8c633d5

@ScarletKuro ScarletKuro merged commit e085e4c into AwesomeAssertions:main Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants