Skip to content

Conversation

@Aurorum
Copy link
Contributor

@Aurorum Aurorum commented Aug 20, 2019

Changes proposed in this Pull Request

  • The Segmented Control toggle should be hidden on desktop displays in the Media Library to prevent an overlap with the slider. It previously was, but I think SegmentedControl: migrate CSS to webpack #35051 caused the CSS that was initially hiding it to be overridden. cc @jsnajdr

Testing instructions

Visit the Media Library and compare.

Before:

Screenshot 2019-08-20 at 08 40 26

After:

Screenshot 2019-08-20 at 08 41 19

Should still appear on mobile though.

@jsnajdr
Copy link
Member

jsnajdr commented Aug 20, 2019

Thanks for fixing this selector specificity issue! There is a similar SegmentedControl regression in Jetpack plans toggle, fixed in #35607.

@jsnajdr jsnajdr merged commit 805b88a into Automattic:master Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants