Fixing Emojis Crash #398
Merged
Fixing Emojis Crash #398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleandroperez
added
bug
danielebogo
approved these changes
Nov 14, 2019
danielebogo
left a comment
danielebogo
left a comment
There was a problem hiding this comment.
@jleandroperez LGTM! And the app doesn't crash!
One thing only (but I don't know if it's related to this PR), I signed in with a new user and the Welcome note disappeared from the Notes list.
Then I selected Trash and again Notes. The Welcome Note wasn't there anymore and the list was empty. I created a new one to test this PR and tried to do the same thing but everything worked as expected.
1 task
Contributor
Author
|
Thank you @danielebogo !!! I'll dig deeper into the Welcome Note issue (couldn't trigger it over here on the first pass). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
In this PR we're mapping a (patched) version of Simperium, which makes sure
Surrogate Pairsaren't split in the middle, and thus, causing invalid unicode strings.@danielebogo May I bug you with a real fun PR?
Thanks in advance!!
Closes #397
Test
Release
RELEASE-NOTES.txtwas updated in 3af363e with: