upgrade mongodb to v3.6.7 #10265
upgrade mongodb to v3.6.7 #10265
Conversation
| client.on('serverDescriptionChanged', ev => { | ||
| const newDescription = ev.newDescription; | ||
| if (newDescription.type === 'Standalone') { | ||
| if (newDescription.type === 'Standalone' || newDescription.type === 'Unknown') { |
There was a problem hiding this comment.
This is not likely to be the correct fix here, because if the topology description is "Unknown" we shouldn't consider that as "reconnected." Is this to try to work around the 'timeout' issue in the first commit's test failures?
There was a problem hiding this comment.
Yes, frankly I am not familiar enough with the connection details, I've been trying to make the tests pass but without luck.
You'd probably be much more efficient at fixing this than me.
There was a problem hiding this comment.
@AbdelrahmanHafez I think I identified the issue and opened up a PR in the MongoDB driver. We'll see what they say, I'm not sure whether this was an intentional change or not.
vkarpov15
left a comment
vkarpov15
left a comment
There was a problem hiding this comment.
I upgraded to [email protected] in master, so this PR is no longer necessary. Thanks 👍
2 participants
No description provided.