Fix memory leak in DefaultWriter uploadBulk0 #2965
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dling The uploadBulk0() method had a critical memory leak when exceptions occurred during bulk upload preparation. ByteBuf objects allocated for dataBuffer and objectBuffer were not being properly released in exception scenarios, causing OutOfDirectMemoryError under high load with network instability. Changes: - Added proper ByteBuf cleanup in catch block for both dataBuffer and objectBuffer - Implemented defensive cleanup with null checks and exception safety - Added comprehensive error logging for better debugging - Ensured all allocated ByteBuf components are released properly Fixes AutoMQ#2938
Adds comprehensive test coverage for the memory leak fix to ensure: - ByteBuf resources are properly cleaned up during exceptions - No memory leaks occur when uploadBulk0() encounters failures - Exception handling preserves the original error while cleaning up resources - Direct memory tracking validates proper cleanup Related to AutoMQ#2938
aaron-seq
requested review from
1sonofqiu,
Gezi-lzq,
superhx and
woshigaopp
as code owners
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes critical memory leak in DefaultWriter.uploadBulk0() method when exceptions occur during bulk upload preparation. ByteBuf objects were not being properly released in exception scenarios.
Fixes #2938