refactor(s3stream): refactor StreamReader Block object #2685
Conversation
lifepuzzlefun
requested review from
Chillax-0v0,
Gezi-lzq,
SCNieh and
superhx
as code owners
daniel-y
requested review from
Copilot
and removed request for
Chillax-0v0 and
SCNieh
There was a problem hiding this comment.
Pull Request Overview
This pull request refactors the StreamReader's Block object by extracting a new ExternalCacheBlock class to handle external cache operations, separating concerns between internal block management and external cache interactions.
- Introduces a new
ExternalCacheBlockclass for handling external cache-specific operations - Updates method signatures and variable declarations to use
ExternalCacheBlockwhere appropriate - Moves some logic from the existing
Blockclass to the newExternalCacheBlockclass
| data.release(); | ||
| data = null; | ||
| } | ||
| }); |
There was a problem hiding this comment.
The loadCf field may be null when release() is called, which would cause a NullPointerException. Consider adding a null check before calling whenComplete.
| }); | |
| if (loadCf != null) { | |
| loadCf.whenComplete((v, ex) -> { | |
| if (data != null) { | |
| data.release(); | |
| data = null; | |
| } | |
| }); | |
| } |
| // the data block is first loaded or evict & reload | ||
| externalBlock.loadCf = dataBlockCache.getBlock(getOptions, objectReader, index).thenAccept(newData -> { | ||
| externalBlock.data = newData; | ||
| handleDataBlockChange(newData); |
There was a problem hiding this comment.
The handleDataBlockChange method is called from ExternalCacheBlock but is defined in the Block class, which will cause a compilation error since ExternalCacheBlock doesn't have access to this method.
| } | ||
| released = true; | ||
| loadCf.whenComplete((nil, ex) -> { | ||
| private void handleDataBlockChange(DataBlock newData) { |
There was a problem hiding this comment.
The handleDataBlockChange method references instance fields (readCompleted, data, freeListenerHandle) from the Block class, but it's being called from ExternalCacheBlock which doesn't have these fields. This will cause compilation errors.
1 participant
No description provided.