Require external packages only if they are dependencies of the generated binary #195
Conversation
| find_package(libappimage REQUIRED) | ||
| endif() | ||
|
|
||
| set(APPIMAGE_UPDATE_QT_UI @APPIMAGE_UPDATE_@BUILD_QT_UI@) |
There was a problem hiding this comment.
This line is clearly broken. Also, in such a file, you should be using unset to remove the temporary variables afterwards. Code style wise, it would make sense to make those lowercase even, or add a _ prefix.
There was a problem hiding this comment.
Sorry about that error, It seems that I'm getting a bit blind.
I thought that the variables could be useful for clients who want to know if certain feature is available.
There was a problem hiding this comment.
I completely agree that this PR is useful, and I appreciate the addition. Please send a new one.
|
I was just about reviewing this PR. I don't like it when broken things are merged. In case you need something merged urgently, feel free to ping me about it on IRC. I cannot keep up with all GitHub notifications. |
No description provided.