feat: support for RN 0.77 & old architecture #566
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
2 tasks
Contributor
|
hello @janicduplessis do you plan to release this soon? RN 77 stable is coming soon and would be great to have this package ready for it. |
Collaborator
|
@vonovak Done! |
kkafar
added a commit
to software-mansion/react-native-screens
that referenced
this pull request
Jan 10, 2025
## Description Adding support for react-native 0.77. After this PR is merged the library will support 0.74+ Paper and 0.77 Fabric. Please note, that I haven't notice any not-handled breaking changes - the library should work with versions down to 0.72 on old architecture and at least down to 0.76 on Fabric, however we won't extend issue resolving to these versions. ## Changes * adjusted example apps on both architectures with changes from upgrade helper, * bumped `safe-area-context` to 5.0.0 (it comes with support for Paper 0.74+) in examples (not lib!), * patched `safe-area-context`: * AppAndFlow/react-native-safe-area-context#566 * Removed patches for and dependencies on reanimated and gesture-handler - awaiting for support, see below 👇🏻 (comment) <-- **this must be restored for e2e to work!!!** * Reanimated uses [the patch](software-mansion/react-native-reanimated#6768 (comment)) * Gesture handler has been set to [current main](https://github.com/software-mansion/react-native-gesture-handler/tree/c3ced78e1608e63b5b3a9bca0c66cc11f4029605) ## Test code and steps to reproduce When doing some quick checks I haven't noticed any obvious regressions. ## Checklist - [ ] Ensured that CI passes --------- Co-authored-by: Marc Rousavy <[email protected]>
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Hey, I'm adding support for RN 0.77 in
react-native-screenssoftware-mansion/react-native-screens#2581 and I stumbled on issue with RNSAC.Basically
BaseViewManagerInterfacehas been removed fromreact-nativeand view manager interfaces & delegates shipped for old arch purposes are no longer valid with 0.77. The PR claims
that this change should be backward compatible with older RN versions for old architecture.
I've included the patch I'm using in
react-native-screensforreact-native-safe-area-contextto make my test project build.Please note that some more changes might be required for full compatibility with 0.77.
Test Plan
I'm using this patch in
react-native-screens, but admit that I haven't tested it in your repository.