Fix retry delay going negative for large retries with exponential delays #2164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Suppress `xUnit1042` warnings.
Add repro for App-vNext#2163.
Add an assertion for the delay's value not being negative.
- Fix retry delays going negative with `DelayBackoffType.Exponential` after 1,024 retries. - Only compute the effective maximum `TimeSpan` once. - Improve regression test. - Assert delays are positive. Resolves App-vNext#2163.
- Add more unit tests related to the exponential delay becoming negative. - Remove redundant Stryker comment.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2164 +/- ##
=======================================
Coverage 83.77% 83.78%
=======================================
Files 313 313
Lines 7148 7152 +4
Branches 1056 1057 +1
=======================================
+ Hits 5988 5992 +4
Misses 789 789
Partials 371 371
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Turns out it's the second part that's (now) unreachable.
peter-csala
reviewed
Jun 25, 2024
- Rename field. - Remove redundant comment. - Simplify repro slightly. - Use `TheoryData<int>` for retry test cases.
peter-csala
approved these changes
Jun 25, 2024
This was referenced Jul 2, 2024
This was referenced Jul 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DelayBackoffType.Exponentialafter 1,024 retries.TimeSpanonce.xUnit1042warnings.Resolves #2163.