Skip to content

Conversation

@martintmk
Copy link
Contributor

@martintmk martintmk commented Feb 4, 2024

Pull Request

The issue or feature being addressed

Contributes to #1901

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk added this to the v8.3.0 milestone Feb 4, 2024
@martintmk
Copy link
Contributor Author

@vany0114 Did I miss anything important?

@codecov
Copy link

codecov bot commented Feb 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (34c0d58) 85.91% compared to head (9a65ab0) 85.91%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1951   +/-   ##
=======================================
  Coverage   85.91%   85.91%           
=======================================
  Files         312      312           
  Lines        6654     6654           
  Branches     1057     1057           
=======================================
  Hits         5717     5717           
  Misses        540      540           
  Partials      397      397           
Flag Coverage Δ
linux 85.91% <ø> (ø)
macos 85.91% <ø> (ø)
windows 85.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@vany0114 vany0114 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be also worth mentioning the other naming changes in the APIs such as:

  • Exception -> Fault
  • Result -> Outcome

Also the Inject prefix vs the AddChaos:

  • InjectException -> AddChaosFault
  • InjectResult -> AddChaosOutcome
  • etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants