-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[Docs] Simmy major differences section #1951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@vany0114 Did I miss anything important? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1951 +/- ##
=======================================
Coverage 85.91% 85.91%
=======================================
Files 312 312
Lines 6654 6654
Branches 1057 1057
=======================================
Hits 5717 5717
Misses 540 540
Partials 397 397
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
vany0114
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be also worth mentioning the other naming changes in the APIs such as:
- Exception -> Fault
- Result -> Outcome
Also the Inject prefix vs the AddChaos:
- InjectException -> AddChaosFault
- InjectResult -> AddChaosOutcome
- etc
Pull Request
The issue or feature being addressed
Contributes to #1901
Confirm the following