Skip to content

add authenticate arg which allows unauthenticated GhApi clients even if GITHUB_TOKEN is set #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 12, 2022
Merged

add authenticate arg which allows unauthenticated GhApi clients even if GITHUB_TOKEN is set #150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions 00_core.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,13 +184,15 @@
"source": [
"#|export\n",
"class GhApi(_GhObj):\n",
" def __init__(self, owner=None, repo=None, token=None, jwt_token=None, debug=None, limit_cb=None, gh_host=None, **kwargs):\n",
" def __init__(self, owner=None, repo=None, token=None, jwt_token=None, debug=None, limit_cb=None, gh_host=None,\n",
" authenticate=True, **kwargs):\n",
" self.headers = { 'Accept': 'application/vnd.github.v3+json' }\n",
" token = token or os.getenv('GITHUB_TOKEN', None)\n",
" jwt_token = jwt_token or os.getenv('GITHUB_JWT_TOKEN', None)\n",
" if jwt_token: self.headers['Authorization'] = 'Bearer ' + jwt_token\n",
" elif token: self.headers['Authorization'] = 'token ' + token\n",
" else: warn('Neither GITHUB_TOKEN nor GITHUB_JWT_TOKEN found: running as unauthenticated')\n",
" if authenticate:\n",
" token = token or os.getenv('GITHUB_TOKEN', None)\n",
" jwt_token = jwt_token or os.getenv('GITHUB_JWT_TOKEN', None)\n",
" if jwt_token: self.headers['Authorization'] = 'Bearer ' + jwt_token\n",
" elif token: self.headers['Authorization'] = 'token ' + token\n",
" else: warn('Neither GITHUB_TOKEN nor GITHUB_JWT_TOKEN found: running as unauthenticated')\n",
" if owner: kwargs['owner'] = owner\n",
" if repo: kwargs['repo' ] = repo\n",
" funcs_ = L(funcs).starmap(_GhVerb, client=self, kwargs=kwargs)\n",
Expand Down
14 changes: 8 additions & 6 deletions ghapi/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,13 +90,15 @@ def print_summary(req:Request):

# %% ../00_core.ipynb 12
class GhApi(_GhObj):
def __init__(self, owner=None, repo=None, token=None, jwt_token=None, debug=None, limit_cb=None, gh_host=None, **kwargs):
def __init__(self, owner=None, repo=None, token=None, jwt_token=None, debug=None, limit_cb=None, gh_host=None,
authenticate=True, **kwargs):
self.headers = { 'Accept': 'application/vnd.github.v3+json' }
token = token or os.getenv('GITHUB_TOKEN', None)
jwt_token = jwt_token or os.getenv('GITHUB_JWT_TOKEN', None)
if jwt_token: self.headers['Authorization'] = 'Bearer ' + jwt_token
elif token: self.headers['Authorization'] = 'token ' + token
else: warn('Neither GITHUB_TOKEN nor GITHUB_JWT_TOKEN found: running as unauthenticated')
if authenticate:
token = token or os.getenv('GITHUB_TOKEN', None)
jwt_token = jwt_token or os.getenv('GITHUB_JWT_TOKEN', None)
if jwt_token: self.headers['Authorization'] = 'Bearer ' + jwt_token
elif token: self.headers['Authorization'] = 'token ' + token
else: warn('Neither GITHUB_TOKEN nor GITHUB_JWT_TOKEN found: running as unauthenticated')
if owner: kwargs['owner'] = owner
if repo: kwargs['repo' ] = repo
funcs_ = L(funcs).starmap(_GhVerb, client=self, kwargs=kwargs)
Expand Down