Skip to content

feat: handle externals all-monorepo option #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

feat: handle externals all-monorepo option #280

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
dd3af26
feat: handle externals all-monorepo option
it-propulse Jan 7, 2022
5636f2b
style: add comments in config.js
it-propulse Jan 7, 2022
a2e386b
docs: update README.md
it-propulse Jan 7, 2022
7e44547
fix: all-monorepo implementation
it-propulse Jan 7, 2022
557555b
refactor: add additionalModuleDirs for the 'all' externals option
it-propulse Feb 11, 2022
b002a4e
style: comment
it-propulse Feb 11, 2022
4008e58
fix: force exclude source-map-support
it-propulse Feb 15, 2022
c715723
test: fix externals-all test
it-propulse Feb 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/webpack.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,9 @@ const ENABLE_CACHING = isLocal ? config.options.caching : false;
// Handle the "all" option in externals
// And add the forceExclude packages to it because they shouldn't be Webpacked
const computedExternals = (
externals === "all" ? [nodeExternals()] : externals
externals === "all"
? [nodeExternals({ additionalModuleDirs: [path.resolve(process.cwd(), "../../node_modules")] })]
: externals
).concat(forceExclude);

const extensions = [
Expand Down
2 changes: 1 addition & 1 deletion tests/externals-all/externals-all.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,5 @@ test("externals all option", async () => {
/*
Ensure that array-first is packaged as a part of the "all" externals option
*/
expect(result).toMatch(/Packing external modules: array-first@\^[\d\\.]+/);
expect(result).toMatch(/Packing external modules: source-map-support, array-first@\^[\d\\.]+/);
});