fix(deps): Revert bumping actions/upload-pages-artifact from 3 to 4 #457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentSmedinga
deleted the
fix/revert-upgrade-upload-pages-artifact-action
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ‘potential breaking changes’ mentioned in their change log were indeed breaking for us, probably because the
.envfile no longer gets considered.Other people have the same problem, see comments on the PR: actions/upload-pages-artifact#102 and a new issue: actions/upload-pages-artifact#129
Reverting for now. Let’s wait and see if an upcoming version of this action adds an option to specify which dotfiles to deploy.