Skip to content

WIP: Process Engine POC #1495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 55 commits into
base: main
Choose a base branch
from
Draft

WIP: Process Engine POC #1495

wants to merge 55 commits into from

Conversation

@danielskovli
Copy link
Contributor

@danielskovli danielskovli commented Sep 26, 2025 •
edited
Loading

Description

A very early draft PR, just to get some visibility on progress and general thought process.

Be kind.

Notes

Target branch should be main once feat/pdf-service-task has merged.

Related issues

bjorntore and others added 30 commits August 27, 2025 15:18
@bjorntore
Add support for service tasks, and add new service tasks for pdf gen…
0ddcb61 
…eration and eFormidling.
@bjorntore
Remove default implementation of hook methods in standard service tasks.
b1bcc4d
@bjorntore
Skip validation if service task.
3ad4174
@bjorntore
Always move to next for service tasks for now. Remoe service task res…
2e79565 
…ult enum and use result classes instead, for expandability.
@bjorntore
Return element type on current task and process tasks to the client.
21f71e8
@bjorntore
Some process engine method renaming.
fcc13bf
@bjorntore
Move current process state validation in process next into it's own m…
35097ee 
…ethod.
@bjorntore
Move "move next" check below result check.
4602c0a
@bjorntore
Update PublicApi_ShouldNotChange_Unintentionally.verified.txt
2cd3e82
@bjorntore
IServiceTask: Rename from params to context. Remove detailed error fi…
9fef45a 
…elds from result class and instead return generic failed ProcessChangeResult.
@bjorntore
Remove ElementType again, as frontend didn't end up using it.
1632b82
@bjorntore
Revert adding Common namespace within ProcessTasks namespace.
6dba954
@bjorntore
Revert NextElement to ProcessNext rename in ProcessController.
b8fa40e
@bjorntore
IProcessEngine: Revert the rename from Next to ProcessNext back to re…
3b33b4a 
…served key word Next.
@bjorntore
Add remark about saving of data when execute returns successful result.
c132415
@bjorntore
Log service task failures as error.
75eab85
@bjorntore
Add test for error message when process is ended.
d375ce4
@bjorntore
Return bpmn element type to frontend.
8e058b5
@bjorntore
Remove useless variables.
010385d
@bjorntore
Merge branch 'main' into feat/pdf-service-task
0124a54
@bjorntore
Merge branch 'main' into feat/pdf-service-task
dbdb128
@danielskovli
WIP
193bd27
@bjorntore
Merge branch 'main' into feat/pdf-service-task
3efdf3e
@bjorntore
Add default body for new method on IPdfService to avoid breaking change.
81aa1c3
@bjorntore
Sanitize a log.
064c17c
@bjorntore
Nitpick: Use PascalCase for named placeholders.
ae04d4c
@bjorntore
Prevent NRE in ProcessReader when no service tasks exists.
8fa3a92
@bjorntore
Add usings in PdfService to dispose streams when done.
dd37c8a
@bjorntore
Hmm
1da33f0
@bjorntore
Hmm 2
74bcaa7
@danielskovli danielskovli added the squad/flyt Issues that belongs to the named squad. label Sep 26, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 26, 2025 •
edited
Loading

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/process-engine-next

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@danielskovli danielskovli self-assigned this Sep 29, 2025
@danielskovli danielskovli moved this to 👷 In progress in Team Altinn Studio Sep 29, 2025
@danielskovli danielskovli added feature Label Pull requests with new features. Used when generation releasenotes backport-ignore This PR is a new feature and should not be cherry-picked onto release branches labels Oct 2, 2025
Base automatically changed from feat/pdf-service-task to main October 30, 2025 10:33
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 3, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
16.0% Coverage on New Code (required ≥ 65%)
0.0% Condition Coverage on New Code (required ≥ 65%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@danielskovli danielskovli

Labels

backport-ignore This PR is a new feature and should not be cherry-picked onto release branches feature Label Pull requests with new features. Used when generation releasenotes squad/flyt Issues that belongs to the named squad.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@danielskovli @bjorntore