Skip to content

Rename InstantiationInstance class #1437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Rename InstantiationInstance class #1437

wants to merge 1 commit into from

Conversation

@elijaydot
Copy link

@elijaydot elijaydot commented Aug 20, 2025 •
edited by danielskovli
Loading

Description

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@martinothamar
Copy link
Contributor

martinothamar commented Aug 21, 2025

Hey! Thanks for contributing. Unfortunately we can't merge this right now as this would incurr a breaking change. There are apps that depend on this name and casing. Once we start work on the next major version we can probably include this

@martinothamar martinothamar added this to the 9.0.0 milestone Aug 21, 2025
@danielskovli danielskovli mentioned this pull request Aug 22, 2025
Closed
5 tasks
danielskovli
danielskovli requested changes Aug 22, 2025
View reviewed changes
Copy link
Contributor

@danielskovli danielskovli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contributions. As was already mentioned, this is a breaking change and cannot be merged at the time being. But if the comments I've added are addressed, we can incorporate this into the v9 release.

src/Altinn.App.Api/Models/InstansiationInstance.cs
Copy link
Contributor

@danielskovli danielskovli Aug 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should be renamed to match the class name.

src/Altinn.App.Api/Controllers/InstancesController.cs
[FromRoute] string org,
[FromRoute] string app,
[FromBody] InstansiationInstance instansiationInstance,
[FromBody] InstantiationInstance InstantiationInstance,
Copy link
Contributor

@danielskovli danielskovli Aug 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parameters and other local variables should be camelCased.

@danielskovli danielskovli changed the title “This PR fixes a small typo in the setup instructions, changing ‘InstansiationInstance’ to ‘InstantiationInstance’.” Renames InstantiationInstance class Aug 22, 2025
@danielskovli danielskovli changed the title Renames InstantiationInstance class Rename InstantiationInstance class Aug 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danielskovli danielskovli danielskovli requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

9.0.0

Development

Successfully merging this pull request may close these issues.

Fix typo in class InstansiationInstance

3 participants

@elijaydot @martinothamar @danielskovli