Skip to content

Implement AuthenticationMethod support in IInstanceClient #1498

@danielskovli

Description

@danielskovli

Description

IDataClient recently implemented a new optional authentication override.

This same methodology should be implemented in IInstanceClient.

Tasks

  • Add optional StorageAuthenticationMethod and CancellationToken parameters to all applicable methods on IInstanceClient
  • Default/undefined usage should resolve to StorageAuthenticationMethod.CurrentUser
  • Inject IAuthenticationTokenResolver and use this for JwtToken resolution (example)
  • Update unit tests to observe that correct tokens are used in the various scenarios. This can be a bit tedious, and borrowin inspiration from the DataClientTests may be helpful

Metadata

Metadata

Labels

good-first-issueIssues that are easy to fix for new team members or external contributorssquad/flytIssues that belongs to the named squad.

Projects

Status

No status

Status

👷 In progress

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions