Skip to content

Conversation

@cammiida
Copy link
Contributor

@cammiida cammiida commented Jul 9, 2025

Description

First version of service task support in the frontend (i.e., failing service tasks).
Assumes that a layout set has been created for the failing service task, but Studio can potentially help set up a default for this. Alternatively, we can consider providing a default view ourselves.

Timeouts are not handled (in cases where TE has configured endless service tasks), as I don't have control over the infrastructure and configs, making it difficult to handle something I'm not fully aware of. This needs to be discussed in more detail when people are back from vacation.

Service Task Failure Support:

  • Added support for automatically navigating to the current task when process/next fails and current task has changed
  • Enhanced process/next button to also handle process/next in service task
  • Added ELEMENT_TYPE element type to shared types

Error Handling Refactoring:

  • Improved error handling in useProcessNext to show user-friendly toast messages instead of full-page errors if app supports it
  • Added generic typing to HttpClientError
Screen.Recording.2025-07-16.at.11.09.27.mov

Related Issue(s)

  • closes #{issue number}

Verification/QA

  • Manual functionality testing
    • I have tested these changes manually
    • Creator of the original issue (or service owner) has been contacted for manual testing (or will be contacted when released in alpha)
    • No testing done/necessary
  • Automated tests
    • Unit test(s) have been added/updated
    • Cypress E2E test(s) have been added/updated
    • No automatic tests are needed here (no functional changes/additions)
    • I want someone to help me make some tests
  • UU/WCAG (follow these guidelines until we have our own)
    • I have tested with a screen reader/keyboard navigation/automated wcag validator
    • No testing done/necessary (no DOM/visual changes)
    • I want someone to help me perform accessibility testing
  • User documentation @ altinn-studio-docs
    • Has been added/updated
    • No functionality has been changed/added, so no documentation is needed
    • I will do that later/have created an issue
  • Support in Altinn Studio
    • Issue(s) created for support in Studio
    • This change/feature does not require any changes to Altinn Studio
  • Sprint board
    • The original issue (or this PR itself) has been added to the Team Apps project and to the current sprint board
    • I don't have permissions to do that, please help me out
  • Labels
    • I have added a kind/* and backport* label to this PR for proper release notes grouping
    • I don't have permissions to add labels, please help me out

@cammiida cammiida added backport This PR should be cherry-picked onto older release branches backport-ignore This PR is a new feature and should not be cherry-picked onto release branches kind/product-feature Pull requests containing new features and removed backport This PR should be cherry-picked onto older release branches labels Jul 9, 2025
@cammiida cammiida self-assigned this Jul 9, 2025
@cammiida cammiida linked an issue Jul 9, 2025 that may be closed by this pull request
7 tasks
@cammiida cammiida marked this pull request as draft July 9, 2025 11:26
@cammiida cammiida changed the base branch from main to refactor/useProcessNext July 9, 2025 11:27
@cammiida cammiida force-pushed the refactor/useProcessNext branch from 4d2e67a to 657abd8 Compare July 10, 2025 16:06
@cammiida cammiida force-pushed the feature/service-task branch from 0c8ee48 to c34b503 Compare July 10, 2025 16:19
@cammiida cammiida force-pushed the refactor/useProcessNext branch from 657abd8 to 1aa7dbf Compare July 14, 2025 06:43
@cammiida cammiida force-pushed the feature/service-task branch from c34b503 to 79fc708 Compare July 14, 2025 06:46
Base automatically changed from refactor/useProcessNext to main July 14, 2025 09:15
@cammiida cammiida force-pushed the feature/service-task branch 2 times, most recently from 92c23b7 to 43c367d Compare July 16, 2025 08:22
@cammiida cammiida marked this pull request as ready for review July 16, 2025 11:33
Copy link
Contributor

@olemartinorg olemartinorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

cammiida added 4 commits July 21, 2025 08:13
  - Remove DisplayErrorProvider in favor of toast notifications
  - Support service task navigation on process next failure
  - Add generic typing to HttpClientError
  - Export useGetInstanceDataQuery for wider usage
@cammiida cammiida force-pushed the feature/service-task branch from 43c367d to 0940b12 Compare July 21, 2025 06:35
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
33.0% Coverage on New Code (required ≥ 45%)
23.53% Condition Coverage on New Code (required ≥ 45%)

See analysis details on SonarQube Cloud

@cammiida cammiida merged commit 0bfd549 into main Jul 21, 2025
14 of 15 checks passed
@cammiida cammiida deleted the feature/service-task branch July 21, 2025 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-ignore This PR is a new feature and should not be cherry-picked onto release branches kind/product-feature Pull requests containing new features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Service task support in user interface

2 participants