fix(websocket): add headers.authentication in connection params #144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add correct headers key to support authentication header
|
@Akryum this would be great if you could merge it. I debugged for quite a while the issue till I found that there is a mismatch between how wsEndpoint and httpEndpoint are being set |
This was referenced Sep 16, 2019
Closed
|
When is this going to be merged in? |
Akryum
changed the title
|
@Akryum thx a lot for your swift merge/release 👍 You were so fast it seems you misspelled the new release 0.12.1 instead of (probably ?) 0.21.1 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add correct headers key to support authentication header