Skip to content

Conversation

@erezrokah
Copy link
Contributor

This fix is similar to #148, to allow using a keyword as a column alias, as SELECT 'Joe' name FROM users is valid (you can check on https://sql.clickhouse.com?query=U0VMRUNUICdKb2UnIG5hbWUgRlJPTSBvdGVsLm90ZWxfbG9ncw)

@coveralls
Copy link

Pull Request Test Coverage Report for Build 17836057158

Details

  • 6 of 8 (75.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.08%) to 50.155%

Changes Missing Coverage Covered Lines Changed/Added Lines %
parser/parser_column.go 6 8 75.0%
Totals Coverage Status
Change from base Build 17815658818: 0.08%
Covered Lines: 7296
Relevant Lines: 14547

💛 - Coveralls

@git-hulk
Copy link
Member

@erezrokah Thanks for your nice catch.

@git-hulk git-hulk merged commit 4350d2e into AfterShip:master Sep 19, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants