Skip to content

Add support for Swift Package Manager #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+23 −4
Open

Add support for Swift Package Manager #89

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f594c0a
Create Package.swift
marionauta Nov 13, 2024
75f453d
Fix Storyboard load in a Swift Package
marionauta Apr 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions EmbedFramework/AdaWebHostViewController.storyboard
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
<?xml version="1.0" encoding="UTF-8"?>
<document type="com.apple.InterfaceBuilder3.CocoaTouch.Storyboard.XIB" version="3.0" toolsVersion="19529" targetRuntime="iOS.CocoaTouch" propertyAccessControl="none" useAutolayout="YES" useTraitCollections="YES" useSafeAreas="YES" colorMatched="YES" initialViewController="D6W-gQ-JwA">
<document type="com.apple.InterfaceBuilder3.CocoaTouch.Storyboard.XIB" version="3.0" toolsVersion="23504" targetRuntime="iOS.CocoaTouch" propertyAccessControl="none" useAutolayout="YES" useTraitCollections="YES" useSafeAreas="YES" colorMatched="YES" initialViewController="D6W-gQ-JwA">
<device id="retina6_1" orientation="portrait" appearance="light"/>
<dependencies>
<deployment identifier="iOS"/>
<plugIn identifier="com.apple.InterfaceBuilder.IBCocoaTouchPlugin" version="19519"/>
<plugIn identifier="com.apple.InterfaceBuilder.IBCocoaTouchPlugin" version="23506"/>
<capability name="Safe area layout guides" minToolsVersion="9.0"/>
<capability name="documents saved in the Xcode 8 format" minToolsVersion="8.0"/>
</dependencies>
Expand All @@ -26,7 +26,7 @@
<!--Offline View Controller-->
<scene sceneID="4Vb-7Z-kTU">
<objects>
<viewController storyboardIdentifier="OfflineViewController" id="dls-Jp-5Mo" customClass="OfflineViewController" customModule="AdaEmbedFramework" customModuleProvider="target" sceneMemberID="viewController">
<viewController storyboardIdentifier="OfflineViewController" id="dls-Jp-5Mo" customClass="OfflineViewController" customModule="AdaEmbedFramework" sceneMemberID="viewController">
<view key="view" contentMode="scaleToFill" id="AJC-ml-g1g">
<rect key="frame" x="0.0" y="0.0" width="414" height="896"/>
<autoresizingMask key="autoresizingMask" widthSizable="YES" heightSizable="YES"/>
Expand Down
2 changes: 1 addition & 1 deletion EmbedFramework/OfflineViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ class OfflineViewController: UIViewController {
storyboard = UIStoryboard(name: "AdaWebHostViewController", bundle: frameworkBundle)
} else {
// Used for if SDK was manually imported
storyboard = UIStoryboard(name: "AdaWebHostViewController", bundle: bundle)
storyboard = UIStoryboard(name: "AdaWebHostViewController", bundle: .module)
}
return storyboard.instantiateViewController(withIdentifier: "OfflineViewController") as? OfflineViewController
}
Expand Down
19 changes: 19 additions & 0 deletions Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
// swift-tools-version:5.3
import PackageDescription

let package = Package(
name: "AdaEmbedFramework",
defaultLocalization: "en",
products: [
.library(
name: "AdaEmbedFramework",
targets: ["AdaEmbedFramework"]
),
],
targets: [
.target(
name: "AdaEmbedFramework",
path: "EmbedFramework"
)
]
)