Skip to content

UDS-2033: CLONE - Content missing after heading #1569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 22, 2025
+10 −4
Merged

UDS-2033: CLONE - Content missing after heading #1569

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8555c8c
feat(unity-react-core): added select tag functionality to headers
juanmitriatti Jul 31, 2025
0f2ff6b
fix(app-rfi): fix heading accessibility issue
davidornelas11 Sep 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/app-rfi/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@ submission payload and add the host's source ID (which serves as an API key and
identifier) to the payload, and then send it off to the RFI submissions service
which processes and routes the submissions to Undergrad, Grad, and ASUOnline
middleware destinations so that the RFI request ultimately lands in the
appropriate Salesforce destination.
appropriate Salesforce destination.


## Installation and Requirements

Expand Down
4 changes: 2 additions & 2 deletions packages/app-rfi/src/components/appVariants/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ const variants = {
CampusProgramHasChoice: validation.CampusProgramHasChoice,
}}
>
<h4>Step 1 of 2</h4>
<div className={'h4'}>Step 1 of 2</div>
<h2>Request information</h2>
<p className="rfi-step1-intro">
To learn more about ASU or a specific program, fill out the form below
Expand All @@ -103,7 +103,7 @@ const variants = {
GdprConsent: validation.GdprConsent,
}}
>
<h4>Step 2 of 2</h4>
<div className={'h4'}>Step 2 of 2</div>
<h2>About me</h2>
<EmailAddress autoFocus gaData={gaData2Of2} />
<FirstName gaData={gaData2Of2} />
Expand Down
6 changes: 5 additions & 1 deletion packages/unity-react-core/src/components/FeedAnatomy/FeedHeader.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,14 +34,18 @@ const FeedHeader = ({
}) => {
const header = { ...defaultProps.header, ...pHeeder };
const ctaButton = { ...defaultProps.ctaButton, ...pCtaButton };
const HeaderTag = header.tag || "h2";
const isNotH2 = HeaderTag !== "h2";

const headerClassName = `text-${header.color} ${isNotH2 ? "h2" : ""}`.trim();

return (
<div
className="row justify-content-between align-items-center pb-6"
data-testid="feed-header"
>
<div className="col-sm-12 col-md-9">
<h2 className={`text-${header.color}`}>{header.text}</h2>
<HeaderTag className={headerClassName}>{header.text}</HeaderTag>
</div>
<ButtonColumn className="col-sm-12 col-md-3">
<GaEventWrapper
Expand Down
1 change: 1 addition & 0 deletions packages/unity-react-core/src/core/types/feed-types.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
* @typedef {Object} FeedHeader
* @property {"white" | "dark"} [color]
* @property {string} [text]
* @property {"h2" | "h3" | "h4" | "div"} [tag]
*/
/**
* @typedef {Object} FeedCtaButton
Expand Down