Return the proper number of bytes copied when reading box namespaces #184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
LGTM |
Contributor
|
Is this tested? If so I'll merge. |
Patater
force-pushed
the
namespace-bytes-copied
branch
from
01fa2c1 to
70623cd
Compare
Box namespaces should always be null-terminated, but just in case they aren't, we will halt instead of returning an unterminated string.
Previously, vmpu_box_namespace_from_id would not include the terminating-null in the bytes copied count it would return. We now include the terminating-null in the bytes copied count.
Patater
force-pushed
the
namespace-bytes-copied
branch
from
70623cd to
57de15f
Compare
Contributor
Author
|
Yes, tested with the current version of example-uvisor-box-id which expects the terminating null to be included in the number of bytes. |
AlessandroA
added a commit
that referenced
this pull request
Mar 7, 2016
Return the proper number of bytes copied when reading box namespaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@AlessandroA @meriac