Add ability to move up/down in list

[josegonzalez]

I don't believe in tests so I'll leave that as an exercise to the merger.

Closes #23.

[ADmad]

Can add a second param $number similar to that of TreeBehavior::moveUp(). Same for the moveDown() method.

[josegonzalez]

Then I'd have to worry about shifting more entities around, is that fine by you?

[ADmad]

Hmm.. If it makes the code too complicated leave it be :)

[josegonzalez]

Yeah I don't think that's quite necessary, and then lends itself to features like "move all the way to top/bottom". Maybe as a separate PR, but this code is probably more useful than the other features.

[ADmad]

I don't believe in tests so I'll leave that as an exercise to the merger.

At least ensure existing tests pass, which don't right now :)

[codecov]

Codecov Report

Merging #24 into master will decrease coverage by 0.76%.
The diff coverage is 92.15%.

@@             Coverage Diff              @@
##             master      #24      +/-   ##
============================================
- Coverage     95.08%   94.31%   -0.77%     
- Complexity       41       54      +13     
============================================
  Files             1        1              
  Lines           122      176      +54     
============================================
+ Hits            116      166      +50     
- Misses            6       10       +4

Impacted Files	Coverage Δ	Complexity Δ
src/Model/Behavior/SequenceBehavior.php	94.31% <92.15%> (-0.77%)	54 <21> (+13)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb827fe...6ccbe01. Read the comment docs.

[josegonzalez]

Okay tests pass again, now you just need to add coverage for this :D

[bravo-kernel]

I don't believe in tests so I'll leave that as an exercise to the merger.

Priceless 🤣

[ADmad]

@bravo-kernel It's no surprise then that the code was non functional. The patch has gems like return _movePosition($entity, $direction = '+'); instead of return $this->_movePosition($entity, $direction = '+'); 😝

[bravo-kernel]

I can't believe I am saying this but that's exactly why I appreciate @jadb's insane method of only adding tests better (nowadays), leaving the implementation to the merger

I fixed shit

[ADmad]

... why I appreciate @jadb's insane method of only adding tests better (nowadays), leaving the implementation to the merger

True TDD :)

[josegonzalez]

Close enough.