Update to objc2 v0.6 #173
Merged
Update to objc2 v0.6 #173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes using the new crate `objc2-core-graphics`, which notably does not have the `CustomData` helper that `core-graphics`. This is probably for the better, as it allows us to avoid a double-boxing of the data.
Member
complexspaces
left a comment
complexspaces
left a comment
There was a problem hiding this comment.
Thank you for work again! I like how this looks for the most part but had a few questions around the modified unsafe.
complexspaces
approved these changes
Feb 13, 2025
Member
complexspaces
left a comment
complexspaces
left a comment
There was a problem hiding this comment.
Looks good now, thanks!
With this update I should also be able to take another stab at iOS support, hopefully soon.
Contributor
|
I would appreciate a release on crates.io with this bump, at your earliest convenience. Thank you! 🫶 |
Contributor
|
Release please! 🥺 🙏 |
Member
|
Released in v3.5.0 on crates.io. Sorry again for the delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes using the new crate
objc2-core-graphics, which notably does not have theCustomDatahelper thatcore-graphics. This is probably for the better, as it allows us to avoid a double-boxing of the data.This also:
extern "C-unwind"inobjc2).dep:*syntax (to avoid breaking changes from added/removed feature flags).