This repository was archived by the owner on Feb 28, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 76
Support RPC v0.2.1 #332
Merged
Merged
Support RPC v0.2.1 #332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # starknet_devnet/blueprints/rpc/call.py # starknet_devnet/blueprints/rpc/structures/payloads.py # starknet_devnet/blueprints/rpc/structures/types.py # starknet_devnet/blueprints/rpc/transactions.py # test/rpc/test_rpc_estimate_fee.py
FabijanC
suggested changes
Nov 4, 2022
1 task
FabijanC
suggested changes
Nov 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to make sure I understood the new changes, you added two new tests: test_get_transaction_by_hash_deploy_account and test_get_deploy_account_transaction_receipt?
Yes, as they are places where the new transaction type can occur. |
FabijanC
approved these changes
Nov 8, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapt to RPC v0.2.1
Significantly smaller PR than for previous versions, introducing changes in RPC v0.2.0 - v0.2.1.
Checklist:
./scripts/format.sh./scripts/lint.sh