-
Notifications
You must be signed in to change notification settings - Fork 555
v0.3.2-beta changes #630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v0.3.2-beta changes #630
Conversation
Merge commits from qa into master
This reverts commit 4d19cf5.
Bump version to stable
Revert "Adding correct miner address on API at the RPC level (POS-553)"
Codecov ReportBase: 56.77% // Head: 56.64% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## qa #630 +/- ##
==========================================
- Coverage 56.77% 56.64% -0.14%
==========================================
Files 607 608 +1
Lines 70338 70470 +132
==========================================
- Hits 39934 39915 -19
- Misses 26973 27130 +157
+ Partials 3431 3425 -6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This commit adds default values to CLI helper and docs. When the default value of a string flag, slice string flag, or map string flag is empty, its helper message won't show any default value.
Add default values to CLI helper and docs
313a4af to
9047365
Compare
9047365 to
b7ed9de
Compare
| $ bor server <flags> | ||
| ``` | ||
|
|
||
| See [here](./cli/server.md) for more flag details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
100.101.90.133
Description
This PR is reverting the RPC change for eth_getBlock
Changes
Breaking changes
Please complete this section if any breaking changes have been made, otherwise delete it
Checklist
Cross repository changes
Testing
Manual tests
Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it
Additional comments
Please post additional comments in this section if you have them, otherwise delete it