Skip to content

Conversation

@temaniarpit27
Copy link
Contributor

@temaniarpit27 temaniarpit27 commented Dec 13, 2022

Description

This PR is reverting the RPC change for eth_getBlock

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply

Cross repository changes

  • This PR requires changes to heimdall
    • In case link the PR here:
  • This PR requires changes to matic-cli
    • In case link the PR here:

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai
  • I have created new e2e tests into express-cli

Manual tests

Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@temaniarpit27 temaniarpit27 marked this pull request as ready for review December 13, 2022 19:20
@temaniarpit27 temaniarpit27 requested a review from a team December 13, 2022 19:20
@codecov
Copy link

codecov bot commented Dec 13, 2022

Codecov Report

Base: 56.77% // Head: 56.64% // Decreases project coverage by -0.13% ⚠️

Coverage data is based on head (9b2407a) compared to base (b7f37c7).
Patch coverage: 30.65% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##               qa     #630      +/-   ##
==========================================
- Coverage   56.77%   56.64%   -0.14%     
==========================================
  Files         607      608       +1     
  Lines       70338    70470     +132     
==========================================
- Hits        39934    39915      -19     
- Misses      26973    27130     +157     
+ Partials     3431     3425       -6     
Impacted Files Coverage Δ
internal/cli/command.go 5.69% <0.00%> (-0.32%) ⬇️
internal/cli/removedb.go 0.00% <ø> (ø)
internal/cli/snapshot.go 0.00% <0.00%> (ø)
params/version.go 36.84% <ø> (ø)
internal/cli/flagset/flagset.go 30.82% <30.00%> (-4.96%) ⬇️
internal/cli/server/config.go 72.16% <100.00%> (ø)
internal/cli/server/flags.go 100.00% <100.00%> (ø)
p2p/discover/v4_udp.go 72.75% <0.00%> (-4.35%) ⬇️
miner/worker.go 72.94% <0.00%> (-1.90%) ⬇️
p2p/discover/table.go 82.48% <0.00%> (-1.83%) ⬇️
... and 16 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

cffls and others added 4 commits December 13, 2022 23:23
This commit adds default values to CLI helper and docs. When the default value of a string flag, slice string flag, or map string flag is empty, its helper message won't show any default value.
Add default values to CLI helper and docs
@cffls cffls force-pushed the arpit/master-to-qa branch from 313a4af to 9047365 Compare December 14, 2022 23:48
@cffls cffls force-pushed the arpit/master-to-qa branch from 9047365 to b7ed9de Compare December 14, 2022 23:49
@temaniarpit27 temaniarpit27 merged commit 7217f79 into qa Dec 15, 2022
@temaniarpit27 temaniarpit27 deleted the arpit/master-to-qa branch December 15, 2022 09:10
$ bor server <flags>
```

See [here](./cli/server.md) for more flag details.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

100.101.90.133

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants