Skip to content

Conversation

@rekibnikufesin
Copy link
Contributor

Description

This PR updates the bor working directory to /var/lib/bor and runs the docker container as a non-root user (bor) as part of the v0.3.0 release. Same code changes as #591 but for the QA branch.

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply

Cross repository changes

  • This PR requires changes to heimdall
    • In case link the PR here:
  • This PR requires changes to matic-cli
    • In case link the PR here:

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai
  • I have created new e2e tests into express-cli

@rekibnikufesin rekibnikufesin marked this pull request as ready for review November 23, 2022 16:57
@rekibnikufesin rekibnikufesin requested a review from a team November 23, 2022 17:31
@rekibnikufesin rekibnikufesin merged commit e468e96 into qa Nov 23, 2022
@rekibnikufesin rekibnikufesin deleted the wbutton/v0.3.0-docker-qa branch November 23, 2022 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants