Skip to content

Conversation

@0xKrishna
Copy link
Contributor

No description provided.

@0xKrishna 0xKrishna marked this pull request as draft April 22, 2022 06:25
@0xKrishna 0xKrishna marked this pull request as ready for review April 22, 2022 06:27
@codecov-commenter
Copy link

Codecov Report

Merging #375 (98123ba) into master (8e3d66c) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 98123ba differs from pull request most recent head 8ea9231. Consider uploading reports for the commit 8ea9231 to get more accurate results

@@            Coverage Diff             @@
##           master     #375      +/-   ##
==========================================
- Coverage   57.51%   57.51%   -0.01%     
==========================================
  Files         553      553              
  Lines       65892    65892              
==========================================
- Hits        37898    37895       -3     
- Misses      24796    24799       +3     
  Partials     3198     3198              
Impacted Files Coverage Δ
params/config.go 33.51% <ø> (ø)
rlp/raw.go 79.37% <0.00%> (-5.63%) ⬇️
eth/protocols/snap/sync.go 71.22% <0.00%> (-1.23%) ⬇️
trie/proof.go 74.11% <0.00%> (-1.07%) ⬇️
p2p/peer.go 73.23% <0.00%> (-1.02%) ⬇️
eth/downloader/queue.go 78.72% <0.00%> (-0.54%) ⬇️
les/costtracker.go 62.43% <0.00%> (-0.53%) ⬇️
les/downloader/downloader.go 75.57% <0.00%> (-0.53%) ⬇️
eth/downloader/downloader.go 75.15% <0.00%> (-0.32%) ⬇️
core/tx_pool.go 71.27% <0.00%> (-0.14%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e3d66c...8ea9231. Read the comment docs.

temaniarpit27
temaniarpit27 previously approved these changes Apr 22, 2022
ssandeep
ssandeep previously approved these changes Apr 22, 2022
@ssandeep
Copy link
Contributor

Can you check with @vcastellm about builder/files/genesys-testnet-v4.json, I think there was a typo in the filename and he had fixed it already.

@0xKrishna
Copy link
Contributor Author

0xKrishna commented Apr 22, 2022

@vcastellm Can you please confirm once available?

@vcastellm
Copy link
Contributor

Missing the typo fix in master 4e74671, I'm going to include it

@vcastellm vcastellm dismissed stale reviews from ssandeep and temaniarpit27 via fe66e29 April 28, 2022 11:11
Copy link
Contributor

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and included the fix in file name

@0xKrishna 0xKrishna merged commit b91293a into master Apr 28, 2022
@0xKrishna 0xKrishna deleted the krishna/update-mumbai-config branch April 28, 2022 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants