Skip to content

Commit ae3d757

Browse files
committed
android: Remove slash from a dependency's Gradle name.
Newer versions of Gradle don't allow project names to contain a variety of characters, including `/`, that have special meaning in filesystems or in various Gradle features: https://docs.gradle.org/4.2/release-notes.html#path-separator-characters-in-names-are-deprecated We don't use such a new version of Gradle for the actual build, but apparently the current versions of both Android Studio, and the default Java extension in VS Code, do use it. Both give obscure errors (though AS's is much more reasonable) with the old name, and successfully complete a Gradle project sync after this fix. The project name is just an identifier for our own use within the Gradle config, so we can rename it however we like; just need to do so everywhere in our Gradle config. An underscore is the choice made by newer upstream versions of `react-native link`: facebook/react-native#18275 so an underscore it is.
1 parent cf1cd2a commit ae3d757

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

android/app/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ dependencies {
171171
compile project(':react-native-image-picker')
172172
compile project(':react-native-orientation')
173173
compile project(':react-native-sentry')
174-
compile project(':@remobile/react-native-toast')
174+
compile project(':@remobile_react-native-toast')
175175
compile project(':react-native-photo-view')
176176
compile project(':react-native-fetch-blob')
177177
compile project(':react-native-sound')

android/settings.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@ include ':react-native-orientation'
99
project(':react-native-orientation').projectDir = new File(rootProject.projectDir, '../node_modules/react-native-orientation/android')
1010
include ':react-native-sentry'
1111
project(':react-native-sentry').projectDir = new File(rootProject.projectDir, '../node_modules/react-native-sentry/android')
12-
include ':@remobile/react-native-toast'
13-
project(':@remobile/react-native-toast').projectDir = new File(rootProject.projectDir, '../node_modules/@remobile/react-native-toast/android')
12+
include ':@remobile_react-native-toast'
13+
project(':@remobile_react-native-toast').projectDir = new File(rootProject.projectDir, '../node_modules/@remobile/react-native-toast/android')
1414
include ':react-native-photo-view'
1515
project(':react-native-photo-view').projectDir = new File(rootProject.projectDir, '../node_modules/react-native-photo-view/android')
1616
include ':react-native-fetch-blob'

0 commit comments

Comments
 (0)