Skip to content

Commit ed596a4

Browse files
oneukumJiri Kosina
authored andcommitted
HID: elo: kill not flush the work
Flushing a work that reschedules itself is not a sensible operation. It needs to be killed. Failure to do so leads to a kernel panic in the timer code. CC: [email protected] Signed-off-by: Oliver Neukum <[email protected]> Reviewed-by: Benjamin Tissoires <[email protected]> Signed-off-by: Jiri Kosina <[email protected]>
1 parent dcc4c2f commit ed596a4

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/hid/hid-elo.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -261,7 +261,7 @@ static void elo_remove(struct hid_device *hdev)
261261
struct elo_priv *priv = hid_get_drvdata(hdev);
262262

263263
hid_hw_stop(hdev);
264-
flush_workqueue(wq);
264+
cancel_delayed_work_sync(&priv->work);
265265
kfree(priv);
266266
}
267267

0 commit comments

Comments
 (0)