From 13f2013fb36a6746261f91dc3a92bc6ca2c7e5b9 Mon Sep 17 00:00:00 2001 From: Jonathan Zempel Date: Mon, 14 Oct 2024 10:14:44 -0400 Subject: [PATCH 1/5] Override UA opacity --- packages/forms/src/styled/select/StyledSelect.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/forms/src/styled/select/StyledSelect.ts b/packages/forms/src/styled/select/StyledSelect.ts index aba02625161..6aa10d676a2 100644 --- a/packages/forms/src/styled/select/StyledSelect.ts +++ b/packages/forms/src/styled/select/StyledSelect.ts @@ -63,6 +63,7 @@ export const StyledSelect = styled(StyledTextInput).attrs({ 'data-garden-version': PACKAGE_VERSION, as: 'select' })` + opacity: 1; /* [1] */ cursor: pointer; text-overflow: ellipsis; From 7ca339fdfe64c0c8e8e38795f48fe71ce5b4469e Mon Sep 17 00:00:00 2001 From: Jonathan Zempel Date: Mon, 14 Oct 2024 10:16:11 -0400 Subject: [PATCH 2/5] Restore docgen extends clause --- packages/tables/src/elements/Table.tsx | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/tables/src/elements/Table.tsx b/packages/tables/src/elements/Table.tsx index 5ff6c0ce004..dd351609de3 100644 --- a/packages/tables/src/elements/Table.tsx +++ b/packages/tables/src/elements/Table.tsx @@ -21,6 +21,9 @@ import { OverflowButton } from './OverflowButton'; import { Row } from './Row'; import { SortableCell } from './SortableCell'; +/** + * @extends TableHTMLAttributes + */ export const TableComponent = React.forwardRef( ({ isReadOnly, size, ...props }, ref) => { const tableContextValue = useMemo( @@ -47,9 +50,6 @@ TableComponent.propTypes = { isReadOnly: PropTypes.bool }; -/** - * @extends TableHTMLAttributes - */ export const Table = TableComponent as typeof TableComponent & { Body: typeof Body; Caption: typeof Caption; From 123592b6ff236025dbddbcaaa6c90adcb11c05e5 Mon Sep 17 00:00:00 2001 From: Jonathan Zempel Date: Mon, 14 Oct 2024 11:15:40 -0400 Subject: [PATCH 3/5] Remove size snapshots --- package-lock.json | 265 +++++++----------- package.json | 1 - packages/.template/.size-snapshot.json | 1 - packages/accordions/.size-snapshot.json | 21 -- packages/avatars/.size-snapshot.json | 21 -- packages/breadcrumbs/.size-snapshot.json | 21 -- packages/buttons/.size-snapshot.json | 21 -- packages/chrome/.size-snapshot.json | 21 -- packages/colorpickers/.size-snapshot.json | 21 -- packages/datepickers/.size-snapshot.json | 21 -- packages/draggable/.size-snapshot.json | 21 -- packages/dropdowns.legacy/.size-snapshot.json | 21 -- packages/dropdowns/.size-snapshot.json | 21 -- packages/forms/.size-snapshot.json | 21 -- packages/grid/.size-snapshot.json | 21 -- packages/loaders/.size-snapshot.json | 21 -- packages/modals/.size-snapshot.json | 21 -- packages/notifications/.size-snapshot.json | 21 -- packages/pagination/.size-snapshot.json | 21 -- packages/tables/.size-snapshot.json | 21 -- packages/tabs/.size-snapshot.json | 21 -- packages/tags/.size-snapshot.json | 21 -- packages/theming/.size-snapshot.json | 21 -- packages/tooltips/.size-snapshot.json | 21 -- packages/typography/.size-snapshot.json | 21 -- utils/build/rollup.config.js | 8 - 26 files changed, 107 insertions(+), 630 deletions(-) delete mode 100644 packages/.template/.size-snapshot.json delete mode 100644 packages/accordions/.size-snapshot.json delete mode 100644 packages/avatars/.size-snapshot.json delete mode 100644 packages/breadcrumbs/.size-snapshot.json delete mode 100644 packages/buttons/.size-snapshot.json delete mode 100644 packages/chrome/.size-snapshot.json delete mode 100644 packages/colorpickers/.size-snapshot.json delete mode 100644 packages/datepickers/.size-snapshot.json delete mode 100644 packages/draggable/.size-snapshot.json delete mode 100644 packages/dropdowns.legacy/.size-snapshot.json delete mode 100644 packages/dropdowns/.size-snapshot.json delete mode 100644 packages/forms/.size-snapshot.json delete mode 100644 packages/grid/.size-snapshot.json delete mode 100644 packages/loaders/.size-snapshot.json delete mode 100644 packages/modals/.size-snapshot.json delete mode 100644 packages/notifications/.size-snapshot.json delete mode 100644 packages/pagination/.size-snapshot.json delete mode 100644 packages/tables/.size-snapshot.json delete mode 100644 packages/tabs/.size-snapshot.json delete mode 100644 packages/tags/.size-snapshot.json delete mode 100644 packages/theming/.size-snapshot.json delete mode 100644 packages/tooltips/.size-snapshot.json delete mode 100644 packages/typography/.size-snapshot.json diff --git a/package-lock.json b/package-lock.json index b322b893209..f966fab17ef 100644 --- a/package-lock.json +++ b/package-lock.json @@ -17,7 +17,6 @@ "@babel/preset-env": "7.25.3", "@babel/preset-react": "7.24.7", "@babel/preset-typescript": "7.24.7", - "@brodybits/rollup-plugin-size-snapshot": "0.15.0", "@rollup/plugin-babel": "6.0.4", "@rollup/plugin-commonjs": "26.0.1", "@rollup/plugin-node-resolve": "15.2.3", @@ -2297,83 +2296,6 @@ "integrity": "sha512-0hYQ8SB4Db5zvZB4axdMHGwEaQjkZzFjQiN9LVYvIFB2nSUHW9tYpxWriPrWDASIxiaXax83REcLxuSdnGPZtw==", "dev": true }, - "node_modules/@brodybits/rollup-plugin-size-snapshot": { - "version": "0.15.0", - "resolved": "https://registry.npmjs.org/@brodybits/rollup-plugin-size-snapshot/-/rollup-plugin-size-snapshot-0.15.0.tgz", - "integrity": "sha512-GvfeKZT/Sn6K8VaNrYbHHJRCv4KbBdExtHm2LGuWoGGQ4bfqsUPAHRqTyUONGQ+qWlu32aYiEhDG+7h61MV8/A==", - "dev": true, - "dependencies": { - "@rollup/plugin-replace": "^5.0.2", - "acorn": "^8.10.0", - "bytes": "^3.1.2", - "chalk": "^4.1.2", - "gzip-size": "^5.1.1", - "jest-diff": "^29.6.4", - "memory-fs": "^0.5.0", - "terser": "^5.19.4", - "webpack": "^5.88.2" - }, - "engines": { - "node": ">=16", - "npm": ">=6", - "yarn": ">=1" - }, - "peerDependencies": { - "rollup": "^3.0.0" - } - }, - "node_modules/@brodybits/rollup-plugin-size-snapshot/node_modules/ansi-styles": { - "version": "4.3.0", - "resolved": "https://registry.npmjs.org/ansi-styles/-/ansi-styles-4.3.0.tgz", - "integrity": "sha512-zbB9rCJAT1rbjiVDb2hqKFHNYLxgtk8NURxZ3IZwD3F6NtxbXZQCnnSi1Lkx+IDohdPlFp222wVALIheZJQSEg==", - "dev": true, - "dependencies": { - "color-convert": "^2.0.1" - }, - "engines": { - "node": ">=8" - }, - "funding": { - "url": "https://github.com/chalk/ansi-styles?sponsor=1" - } - }, - "node_modules/@brodybits/rollup-plugin-size-snapshot/node_modules/chalk": { - "version": "4.1.2", - "resolved": "https://registry.npmjs.org/chalk/-/chalk-4.1.2.tgz", - "integrity": "sha512-oKnbhFyRIXpUuez8iBMmyEa4nbj4IOQyuhc/wy9kY7/WVPcwIO9VA668Pu8RkO7+0G76SLROeyw9CpQ061i4mA==", - "dev": true, - "dependencies": { - "ansi-styles": "^4.1.0", - "supports-color": "^7.1.0" - }, - "engines": { - "node": ">=10" - }, - "funding": { - "url": "https://github.com/chalk/chalk?sponsor=1" - } - }, - "node_modules/@brodybits/rollup-plugin-size-snapshot/node_modules/has-flag": { - "version": "4.0.0", - "resolved": "https://registry.npmjs.org/has-flag/-/has-flag-4.0.0.tgz", - "integrity": "sha512-EykJT/Q1KjTWctppgIAgfSO0tKVuZUjhgMr17kqTumMl6Afv3EISleU7qZUzoXDFTAHTDC4NOoG/ZxU3EvlMPQ==", - "dev": true, - "engines": { - "node": ">=8" - } - }, - "node_modules/@brodybits/rollup-plugin-size-snapshot/node_modules/supports-color": { - "version": "7.2.0", - "resolved": "https://registry.npmjs.org/supports-color/-/supports-color-7.2.0.tgz", - "integrity": "sha512-qpCAvRl9stuOHveKsn7HncJRvv501qIacKzQlO/+Lwxc9+0q2wLyv4Dfvt80/DPn2pqOBsJdDiogXGR9+OvwRw==", - "dev": true, - "dependencies": { - "has-flag": "^4.0.0" - }, - "engines": { - "node": ">=8" - } - }, "node_modules/@colors/colors": { "version": "1.5.0", "resolved": "https://registry.npmjs.org/@colors/colors/-/colors-1.5.0.tgz", @@ -17762,18 +17684,6 @@ "integrity": "sha512-2bmlRpNKBxT/CRmPOlyISQpNj+qSeYvcym/uT0Jx2bMOlKLtSy1ZmLuVxSEKKyor/N5yhvp/ZiG1oE3DEYMSFA==", "dev": true }, - "node_modules/errno": { - "version": "0.1.8", - "resolved": "https://registry.npmjs.org/errno/-/errno-0.1.8.tgz", - "integrity": "sha512-dJ6oBr5SQ1VSd9qkk7ByRgb/1SH4JZjCHSW/mr63/QcXO9zLVxvJ6Oy13nio03rxpSnVDDjFor75SjVeZWPW/A==", - "dev": true, - "dependencies": { - "prr": "~1.0.1" - }, - "bin": { - "errno": "cli.js" - } - }, "node_modules/error-ex": { "version": "1.3.2", "resolved": "https://registry.npmjs.org/error-ex/-/error-ex-1.3.2.tgz", @@ -20665,19 +20575,6 @@ "gunzip-maybe": "bin.js" } }, - "node_modules/gzip-size": { - "version": "5.1.1", - "resolved": "https://registry.npmjs.org/gzip-size/-/gzip-size-5.1.1.tgz", - "integrity": "sha512-FNHi6mmoHvs1mxZAds4PpdCS6QG8B4C1krxJsMutgxl5t3+GlRTzzI3NEkifXx2pVsOvJdOGSmIgDhQ55FwdPA==", - "dev": true, - "dependencies": { - "duplexer": "^0.1.1", - "pify": "^4.0.1" - }, - "engines": { - "node": ">=6" - } - }, "node_modules/handlebars": { "version": "4.7.8", "resolved": "https://registry.npmjs.org/handlebars/-/handlebars-4.7.8.tgz", @@ -27298,55 +27195,6 @@ "map-or-similar": "^1.5.0" } }, - "node_modules/memory-fs": { - "version": "0.5.0", - "resolved": "https://registry.npmjs.org/memory-fs/-/memory-fs-0.5.0.tgz", - "integrity": "sha512-jA0rdU5KoQMC0e6ppoNRtpp6vjFq6+NY7r8hywnC7V+1Xj/MtHwGIbB1QaK/dunyjWteJzmkpd7ooeWg10T7GA==", - "dev": true, - "dependencies": { - "errno": "^0.1.3", - "readable-stream": "^2.0.1" - }, - "engines": { - "node": ">=4.3.0 <5.0.0 || >=5.10" - } - }, - "node_modules/memory-fs/node_modules/isarray": { - "version": "1.0.0", - "resolved": "https://registry.npmjs.org/isarray/-/isarray-1.0.0.tgz", - "integrity": "sha512-VLghIWNM6ELQzo7zwmcg0NmTVyWKYjvIeM83yjp0wRDTmUnrM678fQbcKBo6n2CJEF0szoG//ytg+TKla89ALQ==", - "dev": true - }, - "node_modules/memory-fs/node_modules/readable-stream": { - "version": "2.3.8", - "resolved": "https://registry.npmjs.org/readable-stream/-/readable-stream-2.3.8.tgz", - "integrity": "sha512-8p0AUk4XODgIewSi0l8Epjs+EVnWiK7NoDIEGU0HhE7+ZyY8D1IMY7odu5lRrFXGg71L15KG8QrPmum45RTtdA==", - "dev": true, - "dependencies": { - "core-util-is": "~1.0.0", - "inherits": "~2.0.3", - "isarray": "~1.0.0", - "process-nextick-args": "~2.0.0", - "safe-buffer": "~5.1.1", - "string_decoder": "~1.1.1", - "util-deprecate": "~1.0.1" - } - }, - "node_modules/memory-fs/node_modules/safe-buffer": { - "version": "5.1.2", - "resolved": "https://registry.npmjs.org/safe-buffer/-/safe-buffer-5.1.2.tgz", - "integrity": "sha512-Gd2UZBJDkXlY7GbJxfsE8/nvKkUEU1G38c1siN6QP6a9PT9MmHB8GnpscSmMJSoF8LOIrt8ud/wPtojys4G6+g==", - "dev": true - }, - "node_modules/memory-fs/node_modules/string_decoder": { - "version": "1.1.1", - "resolved": "https://registry.npmjs.org/string_decoder/-/string_decoder-1.1.1.tgz", - "integrity": "sha512-n/ShnvDi6FHbbVfviro+WojiFzv+s8MPMHBczVePfUpDJLwoLT0ht1l4YwBCbi8pJAveEEdnkHyPyTP/mzRfwg==", - "dev": true, - "dependencies": { - "safe-buffer": "~5.1.0" - } - }, "node_modules/meow": { "version": "8.1.2", "resolved": "https://registry.npmjs.org/meow/-/meow-8.1.2.tgz", @@ -32359,6 +32207,48 @@ "integrity": "sha512-eZxlbI8GZscaGS7kkc/trHTT5xgrjH3/1n2JDwusC9iahPKWMRvRjJSAN5mCXviuTGQ/lHnhvv8Q1YTpnfz9gA==", "dev": true }, + "node_modules/netlify-cli/node_modules/@types/body-parser": { + "version": "1.19.2", + "resolved": "https://registry.npmjs.org/@types/body-parser/-/body-parser-1.19.2.tgz", + "integrity": "sha512-ALYone6pm6QmwZoAgeyNksccT9Q4AWZQ6PvfwR37GT6r6FWUPguq6sUmNGSMV2Wr761oQoBxwGGa6DR5o1DC9g==", + "extraneous": true, + "dependencies": { + "@types/connect": "*", + "@types/node": "*" + } + }, + "node_modules/netlify-cli/node_modules/@types/connect": { + "version": "3.4.35", + "resolved": "https://registry.npmjs.org/@types/connect/-/connect-3.4.35.tgz", + "integrity": "sha512-cdeYyv4KWoEgpBISTxWvqYsVy444DOqehiF3fM3ne10AmJ62RSyNkUnxMJXHQWRQQX2eR94m5y1IZyDwBjV9FQ==", + "extraneous": true, + "dependencies": { + "@types/node": "*" + } + }, + "node_modules/netlify-cli/node_modules/@types/express": { + "version": "4.17.13", + "resolved": "https://registry.npmjs.org/@types/express/-/express-4.17.13.tgz", + "integrity": "sha512-6bSZTPaTIACxn48l50SR+axgrqm6qXFIxrdAKaG6PaJk3+zuUr35hBlgT7vOmJcum+OEaIBLtHV/qloEAFITeA==", + "extraneous": true, + "dependencies": { + "@types/body-parser": "*", + "@types/express-serve-static-core": "^4.17.18", + "@types/qs": "*", + "@types/serve-static": "*" + } + }, + "node_modules/netlify-cli/node_modules/@types/express-serve-static-core": { + "version": "4.17.28", + "resolved": "https://registry.npmjs.org/@types/express-serve-static-core/-/express-serve-static-core-4.17.28.tgz", + "integrity": "sha512-P1BJAEAW3E2DJUlkgq4tOL3RyMunoWXqbSCygWo5ZIWTjUgN1YnaXWW4VWl/oc8vs/XoYibEGBKP0uZyF4AHig==", + "extraneous": true, + "dependencies": { + "@types/node": "*", + "@types/qs": "*", + "@types/range-parser": "*" + } + }, "node_modules/netlify-cli/node_modules/@types/http-cache-semantics": { "version": "4.0.4", "resolved": "https://registry.npmjs.org/@types/http-cache-semantics/-/http-cache-semantics-4.0.4.tgz", @@ -32398,6 +32288,12 @@ "@types/istanbul-lib-report": "*" } }, + "node_modules/netlify-cli/node_modules/@types/mime": { + "version": "1.3.2", + "resolved": "https://registry.npmjs.org/@types/mime/-/mime-1.3.2.tgz", + "integrity": "sha512-YATxVxgRqNH6nHEIsvg6k2Boc1JHI9ZbH5iWFFv/MTkchz3b1ieGDa5T0a9RznNdI0KhVbdbWSN+KWWrQZRxTw==", + "extraneous": true + }, "node_modules/netlify-cli/node_modules/@types/node": { "version": "20.14.8", "resolved": "https://registry.npmjs.org/@types/node/-/node-20.14.8.tgz", @@ -32413,12 +32309,34 @@ "integrity": "sha512-37i+OaWTh9qeK4LSHPsyRC7NahnGotNuZvjLSgcPzblpHB3rrCJxAOgI5gCdKm7coonsaX1Of0ILiTcnZjbfxA==", "dev": true }, + "node_modules/netlify-cli/node_modules/@types/qs": { + "version": "6.9.7", + "resolved": "https://registry.npmjs.org/@types/qs/-/qs-6.9.7.tgz", + "integrity": "sha512-FGa1F62FT09qcrueBA6qYTrJPVDzah9a+493+o2PCXsesWHIn27G98TsSMs3WPNbZIEj4+VJf6saSFpvD+3Zsw==", + "extraneous": true + }, + "node_modules/netlify-cli/node_modules/@types/range-parser": { + "version": "1.2.4", + "resolved": "https://registry.npmjs.org/@types/range-parser/-/range-parser-1.2.4.tgz", + "integrity": "sha512-EEhsLsD6UsDM1yFhAvy0Cjr6VwmpMWqFBCb9w07wVugF7w9nfajxLuVmngTIpgS6svCnm6Vaw+MZhoDCKnOfsw==", + "extraneous": true + }, "node_modules/netlify-cli/node_modules/@types/retry": { "version": "0.12.1", "resolved": "https://registry.npmjs.org/@types/retry/-/retry-0.12.1.tgz", "integrity": "sha512-xoDlM2S4ortawSWORYqsdU+2rxdh4LRW9ytc3zmT37RIKQh6IHyKwwtKhKis9ah8ol07DCkZxPt8BBvPjC6v4g==", "dev": true }, + "node_modules/netlify-cli/node_modules/@types/serve-static": { + "version": "1.13.10", + "resolved": "https://registry.npmjs.org/@types/serve-static/-/serve-static-1.13.10.tgz", + "integrity": "sha512-nCkHGI4w7ZgAdNkrEu0bv+4xNV/XDqW+DydknebMOQwkpDGx8G+HTlj7R7ABI8i8nKxVw0wtKPi1D+lPOkh4YQ==", + "extraneous": true, + "dependencies": { + "@types/mime": "^1", + "@types/node": "*" + } + }, "node_modules/netlify-cli/node_modules/@types/yargs-parser": { "version": "20.2.1", "resolved": "https://registry.npmjs.org/@types/yargs-parser/-/yargs-parser-20.2.1.tgz", @@ -32799,6 +32717,22 @@ "url": "https://github.com/sponsors/sindresorhus" } }, + "node_modules/netlify-cli/node_modules/ajv": { + "version": "6.12.6", + "resolved": "https://registry.npmjs.org/ajv/-/ajv-6.12.6.tgz", + "integrity": "sha512-j3fVLgvTo527anyYyJOGTYJbG+vnnQYvE0m5mmkc1TK+nxAppkCLMIL0aZ4dblVCNoGShhm+kzE4ZUykBoMg4g==", + "extraneous": true, + "dependencies": { + "fast-deep-equal": "^3.1.1", + "fast-json-stable-stringify": "^2.0.0", + "json-schema-traverse": "^0.4.1", + "uri-js": "^4.2.2" + }, + "funding": { + "type": "github", + "url": "https://github.com/sponsors/epoberezkin" + } + }, "node_modules/netlify-cli/node_modules/ajv-formats": { "version": "2.1.1", "resolved": "https://registry.npmjs.org/ajv-formats/-/ajv-formats-2.1.1.tgz", @@ -36029,6 +35963,12 @@ "node": ">=8.6.0" } }, + "node_modules/netlify-cli/node_modules/fast-json-stable-stringify": { + "version": "2.1.0", + "resolved": "https://registry.npmjs.org/fast-json-stable-stringify/-/fast-json-stable-stringify-2.1.0.tgz", + "integrity": "sha512-lhd/wF+Lk98HZoTCtlVraHtfh5XYijIjalXck7saUtuanSDyLMxnHhSXEDJqHxD7msR8D0uCmqlkwjCV8xvwHw==", + "extraneous": true + }, "node_modules/netlify-cli/node_modules/fast-json-stringify": { "version": "5.15.1", "resolved": "https://registry.npmjs.org/fast-json-stringify/-/fast-json-stringify-5.15.1.tgz", @@ -37789,6 +37729,15 @@ "ipx": "bin/ipx.mjs" } }, + "node_modules/netlify-cli/node_modules/ipx/node_modules/@netlify/blobs": { + "version": "6.5.0", + "resolved": "https://registry.npmjs.org/@netlify/blobs/-/blobs-6.5.0.tgz", + "integrity": "sha512-wRFlNnL/Qv3WNLZd3OT/YYqF1zb6iPSo8T31sl9ccL1ahBxW1fBqKgF4b1XL7Z+6mRIkatvcsVPkWBcO+oJMNA==", + "extraneous": true, + "engines": { + "node": "^14.16.0 || >=16.0.0" + } + }, "node_modules/netlify-cli/node_modules/ipx/node_modules/lru-cache": { "version": "10.2.0", "resolved": "https://registry.npmjs.org/lru-cache/-/lru-cache-10.2.0.tgz", @@ -38365,6 +38314,12 @@ "fast-deep-equal": "^3.1.3" } }, + "node_modules/netlify-cli/node_modules/json-schema-traverse": { + "version": "0.4.1", + "resolved": "https://registry.npmjs.org/json-schema-traverse/-/json-schema-traverse-0.4.1.tgz", + "integrity": "sha512-xbbCH5dCYU5T8LcEhhuh7HJ88HXuW3qsI3Y0zOZFKfZEHcpWiHU/Jxzk629Brsab/mMiHQti9wMP+845RPe3Vg==", + "extraneous": true + }, "node_modules/netlify-cli/node_modules/jsonc-parser": { "version": "3.2.0", "resolved": "https://registry.npmjs.org/jsonc-parser/-/jsonc-parser-3.2.0.tgz", @@ -46737,12 +46692,6 @@ "integrity": "sha512-D+zkORCbA9f1tdWRK0RaCR3GPv50cMxcrz4X8k5LTSUD1Dkw47mKJEZQNunItRTkWwgtaUSo1RVFRIG9ZXiFYg==", "dev": true }, - "node_modules/prr": { - "version": "1.0.1", - "resolved": "https://registry.npmjs.org/prr/-/prr-1.0.1.tgz", - "integrity": "sha512-yPw4Sng1gWghHQWj0B3ZggWUm4qVbPwPFcRG8KyxiU7J2OHFSoEHKS+EZ3fv5l1t9CyCiop6l/ZYeWbrgoQejw==", - "dev": true - }, "node_modules/psl": { "version": "1.9.0", "resolved": "https://registry.npmjs.org/psl/-/psl-1.9.0.tgz", diff --git a/package.json b/package.json index 19e3135f745..534d69882c9 100644 --- a/package.json +++ b/package.json @@ -35,7 +35,6 @@ "@babel/preset-env": "7.25.3", "@babel/preset-react": "7.24.7", "@babel/preset-typescript": "7.24.7", - "@brodybits/rollup-plugin-size-snapshot": "0.15.0", "@rollup/plugin-babel": "6.0.4", "@rollup/plugin-commonjs": "26.0.1", "@rollup/plugin-node-resolve": "15.2.3", diff --git a/packages/.template/.size-snapshot.json b/packages/.template/.size-snapshot.json deleted file mode 100644 index 0967ef424bc..00000000000 --- a/packages/.template/.size-snapshot.json +++ /dev/null @@ -1 +0,0 @@ -{} diff --git a/packages/accordions/.size-snapshot.json b/packages/accordions/.size-snapshot.json deleted file mode 100644 index a88f2a183f0..00000000000 --- a/packages/accordions/.size-snapshot.json +++ /dev/null @@ -1,21 +0,0 @@ -{ - "index.esm.js": { - "bundled": 33654, - "minified": 25128, - "gzipped": 5590, - "treeshaked": { - "rollup": { - "code": 19426, - "import_statements": 557 - }, - "webpack": { - "code": 21526 - } - } - }, - "index.cjs.js": { - "bundled": 36319, - "minified": 27590, - "gzipped": 5812 - } -} diff --git a/packages/avatars/.size-snapshot.json b/packages/avatars/.size-snapshot.json deleted file mode 100644 index 87fe84b74ac..00000000000 --- a/packages/avatars/.size-snapshot.json +++ /dev/null @@ -1,21 +0,0 @@ -{ - "index.cjs.js": { - "bundled": 21669, - "minified": 15789, - "gzipped": 4081 - }, - "index.esm.js": { - "bundled": 19951, - "minified": 14274, - "gzipped": 3858, - "treeshaked": { - "rollup": { - "code": 11655, - "import_statements": 341 - }, - "webpack": { - "code": 12501 - } - } - } -} diff --git a/packages/breadcrumbs/.size-snapshot.json b/packages/breadcrumbs/.size-snapshot.json deleted file mode 100644 index f967adf5a19..00000000000 --- a/packages/breadcrumbs/.size-snapshot.json +++ /dev/null @@ -1,21 +0,0 @@ -{ - "index.cjs.js": { - "bundled": 5861, - "minified": 4540, - "gzipped": 1632 - }, - "index.esm.js": { - "bundled": 4961, - "minified": 3818, - "gzipped": 1443, - "treeshaked": { - "rollup": { - "code": 3014, - "import_statements": 371 - }, - "webpack": { - "code": 3372 - } - } - } -} diff --git a/packages/buttons/.size-snapshot.json b/packages/buttons/.size-snapshot.json deleted file mode 100644 index 5391d1df50f..00000000000 --- a/packages/buttons/.size-snapshot.json +++ /dev/null @@ -1,21 +0,0 @@ -{ - "index.esm.js": { - "bundled": 23371, - "minified": 16329, - "gzipped": 4624, - "treeshaked": { - "rollup": { - "code": 13223, - "import_statements": 667 - }, - "webpack": { - "code": 14267 - } - } - }, - "index.cjs.js": { - "bundled": 25539, - "minified": 18268, - "gzipped": 4876 - } -} diff --git a/packages/chrome/.size-snapshot.json b/packages/chrome/.size-snapshot.json deleted file mode 100644 index 1e392c702f9..00000000000 --- a/packages/chrome/.size-snapshot.json +++ /dev/null @@ -1,21 +0,0 @@ -{ - "index.cjs.js": { - "bundled": 60634, - "minified": 47198, - "gzipped": 9438 - }, - "index.esm.js": { - "bundled": 55506, - "minified": 42342, - "gzipped": 9072, - "treeshaked": { - "rollup": { - "code": 31957, - "import_statements": 762 - }, - "webpack": { - "code": 35091 - } - } - } -} diff --git a/packages/colorpickers/.size-snapshot.json b/packages/colorpickers/.size-snapshot.json deleted file mode 100644 index 0ba203287e5..00000000000 --- a/packages/colorpickers/.size-snapshot.json +++ /dev/null @@ -1,21 +0,0 @@ -{ - "index.cjs.js": { - "bundled": 55263, - "minified": 36325, - "gzipped": 8536 - }, - "index.esm.js": { - "bundled": 51411, - "minified": 32708, - "gzipped": 8272, - "treeshaked": { - "rollup": { - "code": 26692, - "import_statements": 1005 - }, - "webpack": { - "code": 28819 - } - } - } -} diff --git a/packages/datepickers/.size-snapshot.json b/packages/datepickers/.size-snapshot.json deleted file mode 100644 index 8ee81533651..00000000000 --- a/packages/datepickers/.size-snapshot.json +++ /dev/null @@ -1,21 +0,0 @@ -{ - "index.cjs.js": { - "bundled": 58085, - "minified": 35383, - "gzipped": 7572 - }, - "index.esm.js": { - "bundled": 51975, - "minified": 29919, - "gzipped": 7166, - "treeshaked": { - "rollup": { - "code": 17805, - "import_statements": 1158 - }, - "webpack": { - "code": 26329 - } - } - } -} diff --git a/packages/draggable/.size-snapshot.json b/packages/draggable/.size-snapshot.json deleted file mode 100644 index 3aae0fda515..00000000000 --- a/packages/draggable/.size-snapshot.json +++ /dev/null @@ -1,21 +0,0 @@ -{ - "index.cjs.js": { - "bundled": 20566, - "minified": 14650, - "gzipped": 3827 - }, - "index.esm.js": { - "bundled": 18958, - "minified": 13218, - "gzipped": 3637, - "treeshaked": { - "rollup": { - "code": 10555, - "import_statements": 377 - }, - "webpack": { - "code": 11616 - } - } - } -} diff --git a/packages/dropdowns.legacy/.size-snapshot.json b/packages/dropdowns.legacy/.size-snapshot.json deleted file mode 100644 index 1432d5e1c12..00000000000 --- a/packages/dropdowns.legacy/.size-snapshot.json +++ /dev/null @@ -1,21 +0,0 @@ -{ - "index.cjs.js": { - "bundled": 74832, - "minified": 48345, - "gzipped": 10325 - }, - "index.esm.js": { - "bundled": 68938, - "minified": 42744, - "gzipped": 9951, - "treeshaked": { - "rollup": { - "code": 30112, - "import_statements": 907 - }, - "webpack": { - "code": 34727 - } - } - } -} diff --git a/packages/dropdowns/.size-snapshot.json b/packages/dropdowns/.size-snapshot.json deleted file mode 100644 index a6883af1f28..00000000000 --- a/packages/dropdowns/.size-snapshot.json +++ /dev/null @@ -1,21 +0,0 @@ -{ - "index.cjs.js": { - "bundled": 73611, - "minified": 52290, - "gzipped": 11443 - }, - "index.esm.js": { - "bundled": 67519, - "minified": 46452, - "gzipped": 10807, - "treeshaked": { - "rollup": { - "code": 36514, - "import_statements": 1174 - }, - "webpack": { - "code": 40219 - } - } - } -} diff --git a/packages/forms/.size-snapshot.json b/packages/forms/.size-snapshot.json deleted file mode 100644 index d758cb25428..00000000000 --- a/packages/forms/.size-snapshot.json +++ /dev/null @@ -1,21 +0,0 @@ -{ - "index.cjs.js": { - "bundled": 134934, - "minified": 96552, - "gzipped": 17024 - }, - "index.esm.js": { - "bundled": 126456, - "minified": 88353, - "gzipped": 16631, - "treeshaked": { - "rollup": { - "code": 71215, - "import_statements": 858 - }, - "webpack": { - "code": 76612 - } - } - } -} diff --git a/packages/grid/.size-snapshot.json b/packages/grid/.size-snapshot.json deleted file mode 100644 index 6fb429a7bd4..00000000000 --- a/packages/grid/.size-snapshot.json +++ /dev/null @@ -1,21 +0,0 @@ -{ - "index.cjs.js": { - "bundled": 37197, - "minified": 23768, - "gzipped": 5943 - }, - "index.esm.js": { - "bundled": 33627, - "minified": 20337, - "gzipped": 5784, - "treeshaked": { - "rollup": { - "code": 13816, - "import_statements": 779 - }, - "webpack": { - "code": 17492 - } - } - } -} diff --git a/packages/loaders/.size-snapshot.json b/packages/loaders/.size-snapshot.json deleted file mode 100644 index b80c4e51a38..00000000000 --- a/packages/loaders/.size-snapshot.json +++ /dev/null @@ -1,21 +0,0 @@ -{ - "index.cjs.js": { - "bundled": 20801, - "minified": 16175, - "gzipped": 4233 - }, - "index.esm.js": { - "bundled": 19266, - "minified": 14687, - "gzipped": 4131, - "treeshaked": { - "rollup": { - "code": 11976, - "import_statements": 432 - }, - "webpack": { - "code": 12944 - } - } - } -} diff --git a/packages/modals/.size-snapshot.json b/packages/modals/.size-snapshot.json deleted file mode 100644 index 0fce32c1682..00000000000 --- a/packages/modals/.size-snapshot.json +++ /dev/null @@ -1,21 +0,0 @@ -{ - "index.esm.js": { - "bundled": 42530, - "minified": 30377, - "gzipped": 6885, - "treeshaked": { - "rollup": { - "code": 23267, - "import_statements": 1003 - }, - "webpack": { - "code": 25581 - } - } - }, - "index.cjs.js": { - "bundled": 46600, - "minified": 34041, - "gzipped": 7186 - } -} diff --git a/packages/notifications/.size-snapshot.json b/packages/notifications/.size-snapshot.json deleted file mode 100644 index c8fc917eb44..00000000000 --- a/packages/notifications/.size-snapshot.json +++ /dev/null @@ -1,21 +0,0 @@ -{ - "index.cjs.js": { - "bundled": 43623, - "minified": 29721, - "gzipped": 6548 - }, - "index.esm.js": { - "bundled": 40269, - "minified": 26575, - "gzipped": 6295, - "treeshaked": { - "rollup": { - "code": 17858, - "import_statements": 515 - }, - "webpack": { - "code": 23128 - } - } - } -} diff --git a/packages/pagination/.size-snapshot.json b/packages/pagination/.size-snapshot.json deleted file mode 100644 index 92584aaec03..00000000000 --- a/packages/pagination/.size-snapshot.json +++ /dev/null @@ -1,21 +0,0 @@ -{ - "index.cjs.js": { - "bundled": 23553, - "minified": 16154, - "gzipped": 3819 - }, - "index.esm.js": { - "bundled": 21724, - "minified": 14527, - "gzipped": 3604, - "treeshaked": { - "rollup": { - "code": 11353, - "import_statements": 536 - }, - "webpack": { - "code": 12320 - } - } - } -} diff --git a/packages/tables/.size-snapshot.json b/packages/tables/.size-snapshot.json deleted file mode 100644 index 54e3bc466d7..00000000000 --- a/packages/tables/.size-snapshot.json +++ /dev/null @@ -1,21 +0,0 @@ -{ - "index.esm.js": { - "bundled": 25159, - "minified": 18288, - "gzipped": 4397, - "treeshaked": { - "rollup": { - "code": 13960, - "import_statements": 447 - }, - "webpack": { - "code": 15534 - } - } - }, - "index.cjs.js": { - "bundled": 27935, - "minified": 20843, - "gzipped": 4673 - } -} diff --git a/packages/tabs/.size-snapshot.json b/packages/tabs/.size-snapshot.json deleted file mode 100644 index 5740f4ba377..00000000000 --- a/packages/tabs/.size-snapshot.json +++ /dev/null @@ -1,21 +0,0 @@ -{ - "index.cjs.js": { - "bundled": 10457, - "minified": 7578, - "gzipped": 2342 - }, - "index.esm.js": { - "bundled": 9519, - "minified": 6742, - "gzipped": 2248, - "treeshaked": { - "rollup": { - "code": 5697, - "import_statements": 539 - }, - "webpack": { - "code": 6258 - } - } - } -} diff --git a/packages/tags/.size-snapshot.json b/packages/tags/.size-snapshot.json deleted file mode 100644 index 3e213a699e4..00000000000 --- a/packages/tags/.size-snapshot.json +++ /dev/null @@ -1,21 +0,0 @@ -{ - "index.cjs.js": { - "bundled": 9668, - "minified": 6720, - "gzipped": 2376 - }, - "index.esm.js": { - "bundled": 8668, - "minified": 5920, - "gzipped": 2178, - "treeshaked": { - "rollup": { - "code": 5008, - "import_statements": 377 - }, - "webpack": { - "code": 5451 - } - } - } -} diff --git a/packages/theming/.size-snapshot.json b/packages/theming/.size-snapshot.json deleted file mode 100644 index be93fcd6ff5..00000000000 --- a/packages/theming/.size-snapshot.json +++ /dev/null @@ -1,21 +0,0 @@ -{ - "index.cjs.js": { - "bundled": 21255, - "minified": 13544, - "gzipped": 5204 - }, - "index.esm.js": { - "bundled": 20262, - "minified": 12641, - "gzipped": 5096, - "treeshaked": { - "rollup": { - "code": 3916, - "import_statements": 216 - }, - "webpack": { - "code": 4182 - } - } - } -} diff --git a/packages/tooltips/.size-snapshot.json b/packages/tooltips/.size-snapshot.json deleted file mode 100644 index 49ea683cf40..00000000000 --- a/packages/tooltips/.size-snapshot.json +++ /dev/null @@ -1,21 +0,0 @@ -{ - "index.cjs.js": { - "bundled": 12747, - "minified": 8322, - "gzipped": 2744 - }, - "index.esm.js": { - "bundled": 11660, - "minified": 7334, - "gzipped": 2643, - "treeshaked": { - "rollup": { - "code": 4028, - "import_statements": 395 - }, - "webpack": { - "code": 6734 - } - } - } -} diff --git a/packages/typography/.size-snapshot.json b/packages/typography/.size-snapshot.json deleted file mode 100644 index 7d697ace576..00000000000 --- a/packages/typography/.size-snapshot.json +++ /dev/null @@ -1,21 +0,0 @@ -{ - "index.cjs.js": { - "bundled": 28451, - "minified": 21634, - "gzipped": 5198 - }, - "index.esm.js": { - "bundled": 26030, - "minified": 19327, - "gzipped": 5046, - "treeshaked": { - "rollup": { - "code": 15067, - "import_statements": 473 - }, - "webpack": { - "code": 16466 - } - } - } -} diff --git a/utils/build/rollup.config.js b/utils/build/rollup.config.js index bfb1766755b..ca95dd59e58 100644 --- a/utils/build/rollup.config.js +++ b/utils/build/rollup.config.js @@ -13,7 +13,6 @@ import replace from '@rollup/plugin-replace'; import nodeResolve from '@rollup/plugin-node-resolve'; import typescript from 'rollup-plugin-typescript2'; import { babel } from '@rollup/plugin-babel'; -// import { sizeSnapshot } from '@brodybits/rollup-plugin-size-snapshot'; import analyze from 'rollup-plugin-analyzer'; import cleanup from 'rollup-plugin-cleanup'; import del from 'rollup-plugin-delete'; @@ -84,13 +83,6 @@ export default [ * Remove comments from source files */ cleanup({ extensions: ['js', 'jsx', 'ts', 'tsx'] }), - /** - * Only enforce matching size snapshot files in CI environments - */ - // sizeSnapshot({ - // matchSnapshot: !!process.env.CI, - // printInfo: !!process.env.CI || !!process.env.ANALYZE_BUNDLE - // }), !!process.env.ANALYZE_BUNDLE && analyze({ summaryOnly: true }) ], output: [ From 69a460aeba494d25f24fd7e14aa825a0ad055807 Mon Sep 17 00:00:00 2001 From: Jonathan Zempel Date: Wed, 16 Oct 2024 14:57:20 -0400 Subject: [PATCH 4/5] Restructure message icon HOC --- .../forms/src/elements/common/Message.tsx | 6 +-- .../src/elements/common/MessageIcon.spec.tsx | 24 ++++++++++++ .../forms/src/elements/common/MessageIcon.tsx | 37 ++++++++++++++++++ .../styled/common/StyledMessageIcon.spec.tsx | 11 ------ .../src/styled/common/StyledMessageIcon.ts | 39 ++----------------- packages/forms/src/types/index.ts | 5 +++ 6 files changed, 73 insertions(+), 49 deletions(-) create mode 100644 packages/forms/src/elements/common/MessageIcon.spec.tsx create mode 100644 packages/forms/src/elements/common/MessageIcon.tsx diff --git a/packages/forms/src/elements/common/Message.tsx b/packages/forms/src/elements/common/Message.tsx index 3475d903dc8..51b03f594f3 100644 --- a/packages/forms/src/elements/common/Message.tsx +++ b/packages/forms/src/elements/common/Message.tsx @@ -16,9 +16,9 @@ import { StyledMessage, StyledCheckMessage, StyledRadioMessage, - StyledToggleMessage, - StyledMessageIcon + StyledToggleMessage } from '../../styled'; +import { MessageIcon } from './MessageIcon'; /** * @deprecated use `Field.Message` instead @@ -70,7 +70,7 @@ export const Message = React.forwardRef( return ( - {!!validation && } + {!!validation && } {children} ); diff --git a/packages/forms/src/elements/common/MessageIcon.spec.tsx b/packages/forms/src/elements/common/MessageIcon.spec.tsx new file mode 100644 index 00000000000..73dad043d24 --- /dev/null +++ b/packages/forms/src/elements/common/MessageIcon.spec.tsx @@ -0,0 +1,24 @@ +/** + * Copyright Zendesk, Inc. + * + * Use of this source code is governed under the Apache License, Version 2.0 + * found at http://www.apache.org/licenses/LICENSE-2.0. + */ + +import React from 'react'; +import { render } from 'garden-test-utils'; +import { VALIDATION } from '../../types'; +import { MessageIcon } from './MessageIcon'; + +describe('MessageIcon', () => { + it('renders validation styling', () => { + VALIDATION.forEach(validation => { + const { container } = render(); + const icon = container.firstChild!; + + expect(icon.nodeName).toBe('svg'); + expect(icon).toHaveAttribute('role', 'img'); + expect(icon).not.toHaveAttribute('aria-hidden'); + }); + }); +}); diff --git a/packages/forms/src/elements/common/MessageIcon.tsx b/packages/forms/src/elements/common/MessageIcon.tsx new file mode 100644 index 00000000000..4743f568202 --- /dev/null +++ b/packages/forms/src/elements/common/MessageIcon.tsx @@ -0,0 +1,37 @@ +/** + * Copyright Zendesk, Inc. + * + * Use of this source code is governed under the Apache License, Version 2.0 + * found at http://www.apache.org/licenses/LICENSE-2.0. + */ + +import React, { FC, PropsWithChildren } from 'react'; +import PropTypes from 'prop-types'; +import ErrorIcon from '@zendeskgarden/svg-icons/src/16/alert-error-stroke.svg'; +import WarningIcon from '@zendeskgarden/svg-icons/src/16/alert-warning-stroke.svg'; +import SuccessIcon from '@zendeskgarden/svg-icons/src/16/check-circle-stroke.svg'; +import { StyledMessageIcon } from '../../styled'; +import { IMessageIconProps, VALIDATION } from '../../types'; + +export const MessageIcon: FC> = ({ + validation, + children, + ...props +}) => ( + /* eslint-disable-next-line jsx-a11y/prefer-tag-over-role */ + + {validation + ? { + error: , + success: , + warning: + }[validation] + : children} + +); + +MessageIcon.displayName = 'Field.MessageIcon'; + +MessageIcon.propTypes = { + validation: PropTypes.oneOf(VALIDATION) +}; diff --git a/packages/forms/src/styled/common/StyledMessageIcon.spec.tsx b/packages/forms/src/styled/common/StyledMessageIcon.spec.tsx index 266144f37e5..352faf7dfac 100644 --- a/packages/forms/src/styled/common/StyledMessageIcon.spec.tsx +++ b/packages/forms/src/styled/common/StyledMessageIcon.spec.tsx @@ -9,7 +9,6 @@ import React from 'react'; import { render } from 'garden-test-utils'; import { StyledMessageIcon } from './StyledMessageIcon'; import TestIcon from '@zendeskgarden/svg-icons/src/16/gear-stroke.svg'; -import { VALIDATION } from '../../types'; describe('StyledMessageIcon', () => { it('renders the expected element', () => { @@ -21,14 +20,4 @@ describe('StyledMessageIcon', () => { expect(container.firstChild!.nodeName).toBe('svg'); }); - - describe('Validation', () => { - it('renders validation styling', () => { - VALIDATION.forEach(validation => { - const { container } = render(); - - expect(container.firstChild!.nodeName).toBe('svg'); - }); - }); - }); }); diff --git a/packages/forms/src/styled/common/StyledMessageIcon.ts b/packages/forms/src/styled/common/StyledMessageIcon.ts index 1c1b6826033..642738bb6fc 100644 --- a/packages/forms/src/styled/common/StyledMessageIcon.ts +++ b/packages/forms/src/styled/common/StyledMessageIcon.ts @@ -6,45 +6,14 @@ */ import styled from 'styled-components'; -import React, { Children, PropsWithChildren } from 'react'; -import { retrieveComponentStyles } from '@zendeskgarden/react-theming'; -import AlertError from '@zendeskgarden/svg-icons/src/16/alert-error-stroke.svg'; -import AlertWarning from '@zendeskgarden/svg-icons/src/16/alert-warning-stroke.svg'; -import CheckCircle from '@zendeskgarden/svg-icons/src/16/check-circle-stroke.svg'; -import { Validation } from '../../types'; - -const MessageIcon: React.FC> = ({ - children, - validation, - ...props -}) => { - let retVal; - - if (validation === 'error') { - retVal = React.createElement(AlertError, props); - } else if (validation === 'success') { - retVal = React.createElement(CheckCircle, props); - } else if (validation === 'warning') { - retVal = React.createElement(AlertWarning, props); - } else { - retVal = React.cloneElement(Children.only(children as any)); - } - - return retVal; -}; +import { retrieveComponentStyles, StyledBaseIcon } from '@zendeskgarden/react-theming'; const COMPONENT_ID = 'forms.input_message_icon'; -interface IStyledMessageIconProps { - validation?: Validation; -} - -export const StyledMessageIcon = styled(MessageIcon).attrs({ +export const StyledMessageIcon = styled(StyledBaseIcon).attrs({ 'data-garden-id': COMPONENT_ID, - 'data-garden-version': PACKAGE_VERSION, - 'aria-hidden': null, - role: 'img' -})` + 'data-garden-version': PACKAGE_VERSION +})` width: ${props => props.theme.iconSizes.md}; height: ${props => props.theme.iconSizes.md}; diff --git a/packages/forms/src/types/index.ts b/packages/forms/src/types/index.ts index 2b7e780aa78..b1bee65e3e9 100644 --- a/packages/forms/src/types/index.ts +++ b/packages/forms/src/types/index.ts @@ -59,6 +59,11 @@ export interface IMessageProps extends HTMLAttributes { validationLabel?: string; } +export interface IMessageIconProps { + /** Applies validation state styling */ + validation?: Validation; +} + export interface IRadioProps extends InputHTMLAttributes { /** Applies compact styling */ isCompact?: IFieldsetProps['isCompact']; From 620600c3a33dacb91029a5c3900b40a39109ab34 Mon Sep 17 00:00:00 2001 From: Jonathan Zempel Date: Wed, 16 Oct 2024 15:03:31 -0400 Subject: [PATCH 5/5] Remove size snapshot add from precommit --- .husky/pre-commit | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.husky/pre-commit b/.husky/pre-commit index 0bf7474f9b2..1d4da033ae9 100755 --- a/.husky/pre-commit +++ b/.husky/pre-commit @@ -1 +1 @@ -npm exec lint-staged && npm run build -- --since HEAD --exclude-dependents && git add packages/**/.size-snapshot.json +npm exec lint-staged && npm run build -- --since HEAD --exclude-dependents