net: fib: fix incorrect call_rcu_bh()

edumazet · davem330 · commit 0c03eca3d995 · 2012-08-08T15:57:46.000-07:00
After IP route cache removal, I believe rcu_bh() has very little use and
we should remove this RCU variant, since it adds some cycles in fast
path.

Anyway, the call_rcu_bh() use in fib_true is obviously wrong, since
some users only assert rcu_read_lock().

Signed-off-by: Eric Dumazet &lt;edumazet@google.com&gt;
Cc: "Paul E. McKenney" &lt;paulmck@linux.vnet.ibm.com&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
diff --git a/net/ipv4/fib_trie.c b/net/ipv4/fib_trie.c
@@ -367,7 +367,7 @@ static void __leaf_free_rcu(struct rcu_head *head)
 
 static inline void free_leaf(struct leaf *l)
 {
-	call_rcu_bh(&l->rcu, __leaf_free_rcu);
+	call_rcu(&l->rcu, __leaf_free_rcu);
 }
 
 static inline void free_leaf_info(struct leaf_info *leaf)

Original file line number	Diff line number	Diff line change
`@@ -367,7 +367,7 @@ static void __leaf_free_rcu(struct rcu_head *head)`
`367`	`367`
`368`	`368`	`static inline void free_leaf(struct leaf *l)`
`369`	`369`	`{`
`370`		`- call_rcu_bh(&l->rcu, __leaf_free_rcu);`
	`370`	`+ call_rcu(&l->rcu, __leaf_free_rcu);`
`371`	`371`	`}`
`372`	`372`
`373`	`373`	`static inline void free_leaf_info(struct leaf_info *leaf)`