Skip to content

Drop tox #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 4, 2022
Merged

Drop tox #384

merged 7 commits into from
Nov 4, 2022

Conversation

@jakirkham
Copy link
Member

@jakirkham jakirkham commented Nov 3, 2022 •
edited
Loading

Remove tox from numcodecs. Analogous to PR ( zarr-developers/zarr-python#1219 ).

TODO:

  • Unit tests and/or doctests in docstrings
  • tox -e py310 passes locally
  • Docstrings and API docs for any new/modified user-facing classes and functions
  • Changes documented in docs/release.rst
  • tox -e docs passes locally
  • GitHub Actions CI passes
  • Test coverage to 100% (Coveralls passes)

@jakirkham jakirkham mentioned this pull request Nov 3, 2022
Merged
7 tasks
@jakirkham
Copy link
Member Author

jakirkham commented Nov 3, 2022

@joshmoore could you please review this?

joshmoore
joshmoore approved these changes Nov 4, 2022
View reviewed changes
Copy link
Member

@joshmoore joshmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshmoore joshmoore merged commit 088434e into zarr-developers:main Nov 4, 2022
@jakirkham jakirkham deleted the drop_tox branch November 4, 2022 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joshmoore joshmoore joshmoore approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jakirkham @joshmoore