Fix JSON Schema #6973
Open
Fix JSON Schema #6973
+36
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`"type": "mixed"` is not valid JSON Schema. This results in errors in features such as VS Code's automatic validation: ``` Schema 'Yarn Config (.yarnrc.yml) - Yarnrc configuration files (yarnrc.json)' is not valid: /properties/httpTimeout/type : must be equal to one of the allowed values /properties/httpTimeout/type : must be array /properties/httpTimeout/type : must match a schema in anyOfYAML(768) ``` `type` could be omitted completely (it's redundant with `oneOf`) but is required by the Docusaurus configuration (via https://github.com/arcanis/react-json-doc?). To prevent further regressions, I added validation of the JSON Schemas using [AJV](https://ajv.js.org/). If there's a better place for this test to reside, please let me know. Fixes yarnpkg#6972
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
"type": "mixed"is not valid JSON Schema. This results in errors in features such as VS Code's automatic validation:Resolves #6972
How did you fix it?
typecould be omitted completely (it's redundant withoneOf) but is required by the Docusaurus configuration (viahttps://github.com/arcanis/react-json-doc?), so I added it as an array.
To prevent further regressions, I added validation of the JSON Schemas using AJV. If there's a better place for this test to reside, please let me know.
Checklist