Skip to content

Conversation

@dfilipidisz
Copy link
Contributor

Continue work on #1240.

Transformed var statements to const and let, added eslint rules to enforce them.

Not included:

  • Examples in docs not updated
  • Test code blocks not updated

If there is anything I can do to make these large scale changes easier to handle, please let me know!

@ljharb
Copy link
Member

ljharb commented Jun 27, 2017

Was this done manually, or solely with eslint --fix?

@dfilipidisz
Copy link
Contributor Author

First I ran eslint ---fix than I fixed the ~15 cases where it couldn't do it by itself.

Copy link
Collaborator

@lencioni lencioni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Moving forward it would be preferable to put all of the automated changes in their own commit and follow up with commits that contain only manual changes. That would make it easier to review.

@dfilipidisz
Copy link
Contributor Author

Okay, I'll definitely do that in the future! Thanks for guiding me along this, I don't have much experience in open source :)

@lencioni lencioni merged commit d672588 into jsx-eslint:master Jun 27, 2017
@lencioni
Copy link
Collaborator

I don't have much experience in open source :)

You are doing a great job! Keep it up 💃

@dfilipidisz dfilipidisz deleted the transform-variables branch June 27, 2017 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants