[GPU] Remove implicit bool cast in memexport checks

Triang3l · Triang3l · commit ed64e3072bde · 2023-05-05T21:38:45.000+03:00
diff --git a/src/xenia/gpu/d3d12/d3d12_command_processor.cc b/src/xenia/gpu/d3d12/d3d12_command_processor.cc
@@ -2125,7 +2125,7 @@ bool D3D12CommandProcessor::IssueDraw(xenos::PrimitiveType primitive_type,
     return false;
   }
   pipeline_cache_->AnalyzeShaderUcode(*vertex_shader);
-  bool memexport_used_vertex = vertex_shader->memexport_eM_written();
+  bool memexport_used_vertex = vertex_shader->memexport_eM_written() != 0;
 
   // Pixel shader analysis.
   bool primitive_polygonal = draw_util::IsPrimitivePolygonal(regs);
@@ -2154,7 +2154,7 @@ bool D3D12CommandProcessor::IssueDraw(xenos::PrimitiveType primitive_type,
     }
   }
   bool memexport_used_pixel =
-      pixel_shader && pixel_shader->memexport_eM_written();
+      pixel_shader && (pixel_shader->memexport_eM_written() != 0);
   bool memexport_used = memexport_used_vertex || memexport_used_pixel;
 
   if (!BeginSubmission(true)) {
diff --git a/src/xenia/gpu/vulkan/vulkan_command_processor.cc b/src/xenia/gpu/vulkan/vulkan_command_processor.cc
@@ -2175,7 +2175,7 @@ bool VulkanCommandProcessor::IssueDraw(xenos::PrimitiveType prim_type,
     return false;
   }
   pipeline_cache_->AnalyzeShaderUcode(*vertex_shader);
-  bool memexport_used_vertex = vertex_shader->memexport_eM_written();
+  bool memexport_used_vertex = vertex_shader->memexport_eM_written() != 0;
 
   // Pixel shader analysis.
   bool primitive_polygonal = draw_util::IsPrimitivePolygonal(regs);

Original file line number	Diff line number	Diff line change
`@@ -2125,7 +2125,7 @@ bool D3D12CommandProcessor::IssueDraw(xenos::PrimitiveType primitive_type,`
`2125`	`2125`	`return false;`
`2126`	`2126`	`}`
`2127`	`2127`	`pipeline_cache_->AnalyzeShaderUcode(*vertex_shader);`
`2128`		`- bool memexport_used_vertex = vertex_shader->memexport_eM_written();`
	`2128`	`+ bool memexport_used_vertex = vertex_shader->memexport_eM_written() != 0;`
`2129`	`2129`
`2130`	`2130`	`// Pixel shader analysis.`
`2131`	`2131`	`bool primitive_polygonal = draw_util::IsPrimitivePolygonal(regs);`
`@@ -2154,7 +2154,7 @@ bool D3D12CommandProcessor::IssueDraw(xenos::PrimitiveType primitive_type,`
`2154`	`2154`	`}`
`2155`	`2155`	`}`
`2156`	`2156`	`bool memexport_used_pixel =`
`2157`		`- pixel_shader && pixel_shader->memexport_eM_written();`
	`2157`	`+ pixel_shader && (pixel_shader->memexport_eM_written() != 0);`
`2158`	`2158`	`bool memexport_used = memexport_used_vertex \|\| memexport_used_pixel;`
`2159`	`2159`
`2160`	`2160`	`if (!BeginSubmission(true)) {`
Original file line number	Diff line number	Diff line change
`@@ -2175,7 +2175,7 @@ bool VulkanCommandProcessor::IssueDraw(xenos::PrimitiveType prim_type,`
`2175`	`2175`	`return false;`
`2176`	`2176`	`}`
`2177`	`2177`	`pipeline_cache_->AnalyzeShaderUcode(*vertex_shader);`
`2178`		`- bool memexport_used_vertex = vertex_shader->memexport_eM_written();`
	`2178`	`+ bool memexport_used_vertex = vertex_shader->memexport_eM_written() != 0;`
`2179`	`2179`
`2180`	`2180`	`// Pixel shader analysis.`
`2181`	`2181`	`bool primitive_polygonal = draw_util::IsPrimitivePolygonal(regs);`