CA-409710: Clean old database backup files

The old database backup files should also be cleaned.

Signed-off-by: Bengang Yuan <[email protected]>

Author: BengangY

scripts/xe-backup-metadata

@@ -222,7 +222,7 @@ if [ ${leave_mounted} -eq 0 ]; then
   fi
 
   # invoke logrotate to rotate over old pool db backups
-  echo -n "Rotating old backups: "
+  echo -n "Rotating old DB backups: "
   logrotate -f "${lrconf}"
   num_found=$(find "${mnt}" -name '*.db.*' | wc -l)
   echo "found ${num_found}"
@@ -232,6 +232,14 @@ if [ ${leave_mounted} -eq 0 ]; then
   ${XE} pool-dump-database file-name="${mnt}/${pool_uuid}.db"
   echo done
 
+  # clean the old pool database dump
+  echo -n "Cleaning old DB backups: "
+  todelete=$(cd "${mnt}" && ls -1tr ${pool_uuid}.db* | head -n -${history_kept} | xargs echo)
+  for dbfile in ${todelete}; do
+    rm -f "${mnt}/${dbfile}"
+  done
+  echo done
+
   # backup the VM metadata for each VM in the pool into a dated directory
   datetime=$(date +%F-%H-%M-%S)
   metadir="${mnt}/metadata/${datetime}"