CA-409710: Clean old database backup files

The old database backup files should also be cleaned.

Signed-off-by: Bengang Yuan <[email protected]>

Author: BengangY

scripts/xe-backup-metadata

@@ -222,28 +222,37 @@ if [ ${leave_mounted} -eq 0 ]; then
   fi
 
   # invoke logrotate to rotate over old pool db backups
-  echo -n "Rotating old backups: "
+  echo -n "Rotating old DB backups: "
   logrotate -f "${lrconf}"
   num_found=$(find "${mnt}" -name '*.db.*' | wc -l)
   echo "found ${num_found}"
 
   # perform the pool database dump
   echo -n "Backing up pool database: "
   ${XE} pool-dump-database file-name="${mnt}/${pool_uuid}.db"
-  echo done
+  echo "done"
+
+  # clean the old pool database dump
+  echo -n "Cleaning old DB backups: "
+  todelete=$(cd "${mnt}" && ls -1tr ${pool_uuid}.db* | head -n -"${history_kept}" | xargs echo)
+  for dbfile in ${todelete}; do
+    rm -f "${mnt}/${dbfile}"
+  done
+  echo "done"
 
   # backup the VM metadata for each VM in the pool into a dated directory
   datetime=$(date +%F-%H-%M-%S)
   metadir="${mnt}/metadata/${datetime}"
   mkdir -p "${metadir}"
   echo -n "Cleaning old VM metadata: "
   IFS=" "
-  todelete=$(cd "${mnt}/metadata" && ls -1 |sort -n | head -n -${history_kept} | xargs echo)
+  todelete=$(cd "${mnt}/metadata" && ls -1 |sort -n | head -n -"${history_kept}" | xargs echo)
   for dir in ${todelete}; do
     rm -rf "${mnt}/metadata/${dir}"
   done
-  echo done
+  echo "done"
   IFS=","
+
   echo -n "Backing up SR metadata: "
   mkdir -p "${metadir}"
   "@LIBEXECDIR@/backup-sr-metadata.py" -f "${metadir}/SRMETA.xml"