[ObjCRuntime] Specify the string comparison to use when comparing strings in Runtime.IsARM64CallingConvention. #14840
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ings in Runtime.IsARM64CallingConvention. This may in some cases delay loading big chunks of .NET's globalization code at startup until after reaching user's Main method.
rolfbjarne
added
not-notes-worthy
Collaborator
📋 [PR Build] API Diff 📋API Current PR diff✅ API Diff (from PR only) (no change) View dotnet API diffView dotnet legacy API diffAPI diff✅ API Diff from stable View dotnet API diffView dotnet legacy API diffGenerator diff✅ Generator Diff (no change) Pipeline on Agent XAMBOT-1108.Monterey |
Therzok
approved these changes
Apr 28, 2022
Collaborator
Collaborator
💻 [PR Build] Tests on macOS Mac Catalina (10.15) passed 💻✅ All tests on macOS Mac Catalina (10.15) passed. Pipeline on Agent |
Collaborator
❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌Failed tests are:
Pipeline on Agent |
dalexsoto
approved these changes
Apr 28, 2022
tj-devel709
approved these changes
Apr 28, 2022
Collaborator
❌ [CI Build] Tests failed on VSTS: simulator tests iOS ❌Tests failed on VSTS: simulator tests iOS. Test results2 tests failed, 146 tests passed.Failed tests
Pipeline on Agent XAMBOT-1108.Monterey' |
chamons
approved these changes
Apr 28, 2022
Member
Author
|
Test failures are unrelated (https://github.com/xamarin/maccore/issues/2558). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may in some cases delay loading big chunks of .NET's globalization code
at startup until after reaching user's Main method.