Skip to content
This repository was archived by the owner on May 15, 2024. It is now read-only.

Conversation

@jamesmontemagno
Copy link
Collaborator

Description of Change

Add in these two properties and also fix UWP for NaN on these

Bugs Fixed

Provide links to issues here. Ensure that a GitHub issue was created for your feature or bug fix before sending PR.

API Changes

List all API changes here (or just put None), example:

Added:

  • double? - double? Location.Course { get; set; }
  • double? - double? Location.Speed { get; set; }

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Has samples (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Updated documentation (see walkthrough)

Mrnikbobjeff and others added 2 commits August 3, 2018 10:06
* Implemented maps as mentioned in branch name issue. also fixed a spelling mistake

* Finished reset of fork

* LocationBearing

* removed requirements

* Speed and bearing docs

* braces & equality

* Renamed Bearing to Heading

* Heading in location
@jamesmontemagno jamesmontemagno added the awaiting-review This PR needs to have a set of eyes on it label Aug 3, 2018
@jamesmontemagno jamesmontemagno added this to the 0.10.0-preview milestone Aug 3, 2018
@jamesmontemagno jamesmontemagno requested a review from Redth August 3, 2018 19:13
@dend
Copy link
Contributor

dend commented Aug 3, 2018

✅ Validation status: passed

File Status Preview URL Details
Samples/Samples/ViewModel/GeolocationViewModel.cs ✅Succeeded
Xamarin.Essentials/Types/Location.shared.cs ✅Succeeded
Xamarin.Essentials/Types/LocationExtensions.android.cs ✅Succeeded
Xamarin.Essentials/Types/LocationExtensions.ios.cs ✅Succeeded
Xamarin.Essentials/Types/LocationExtensions.uwp.cs ✅Succeeded
docs/en/FrameworksIndex/xamarin-essentials-android.xml ✅Succeeded
docs/en/FrameworksIndex/xamarin-essentials-ios.xml ✅Succeeded
docs/en/FrameworksIndex/xamarin-essentials-uwp.xml ✅Succeeded
docs/en/FrameworksIndex/xamarin-essentials.xml ✅Succeeded
docs/en/Xamarin.Essentials/Location.xml ✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Redth
Redth previously approved these changes Aug 14, 2018
@dend
Copy link
Contributor

dend commented Aug 14, 2018

✅ Validation status: passed

File Status Preview URL Details
Samples/Samples/ViewModel/GeolocationViewModel.cs ✅Succeeded
Xamarin.Essentials/Types/Location.shared.cs ✅Succeeded
Xamarin.Essentials/Types/LocationExtensions.android.cs ✅Succeeded
Xamarin.Essentials/Types/LocationExtensions.ios.cs ✅Succeeded
Xamarin.Essentials/Types/LocationExtensions.uwp.cs ✅Succeeded
docs/en/FrameworksIndex/xamarin-essentials-android.xml ✅Succeeded
docs/en/FrameworksIndex/xamarin-essentials-ios.xml ✅Succeeded
docs/en/FrameworksIndex/xamarin-essentials-uwp.xml ✅Succeeded
docs/en/FrameworksIndex/xamarin-essentials.xml ✅Succeeded
docs/en/Xamarin.Essentials/Location.xml ✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@Redth Redth merged commit 9d81a76 into master Aug 14, 2018
@Redth Redth deleted the feature/issue-400 branch August 14, 2018 18:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

awaiting-review This PR needs to have a set of eyes on it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants